Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EcalMatacqDigi: change default values of triggerType and attenuation_dB #45329

Closed
wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

PR description:

This fixes the following warnings (emitted by cuda compiler):

  src/DataFormats/EcalDigi/interface/EcalMatacqDigi.h(287): warning #68-D: integer conversion resulted in a change of sign
       attenuation_dB_ = -1;
                        ^

  src/DataFormats/EcalDigi/interface/EcalMatacqDigi.h(279): warning #68-D: integer conversion resulted in a change of sign
       triggerType_ = -1;

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please test for el9_aarch64_gcc12

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45329/40748

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DataFormats/EcalDigi (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @missirol, @mmusich, @rchatter, @rovere, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 27, 2024

duplicate of #45303 ?

@thomreis
Copy link
Contributor

Hi @iarspider this looks like a parallel attempt to the fix in #45303

@iarspider
Copy link
Contributor Author

please abort

@iarspider
Copy link
Contributor Author

@mmusich @thomreis thanks. I will close this PR in favor of #45303.

@iarspider
Copy link
Contributor Author

@cmsbuild please close

@cmsbuild cmsbuild closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants