DataFormats/EcalDigi: change triggerType_ and attenuation_dB_ to explicitly signed types

[dan131riley]

PR description:

We are getting compilation warnings from nvcc on aarch64:

  src/DataFormats/EcalDigi/interface/EcalMatacqDigi.h(279): warning #68-D: integer conversion resulted in a change of sign
       triggerType_ = -1;
                     ^
  src/DataFormats/EcalDigi/interface/EcalMatacqDigi.h(287): warning #68-D: integer conversion resulted in a change of sign
       attenuation_dB_ = -1;

These are being produced because those data members are declared as type char, which does not have a defined signedness, and nvcc on aarch64 defaults to unsigned char. This PR changes those values to an explicitly signed type int8_t. I'd consider this a real bug, as making assumptions about whether char is signed or not can lead to genuine logic errors.

This change does require incrementing the ClassVersion.

As an aside: since the other member data in this DataFormat use ROOT types, I considered using a signed char ROOT type--but they don't have one! Char_t claims to be signed, but it is a typedef for bare char, so the ROOT type has exactly the same bug of assuming that char has a well-defined signedness. Issue opened at root-project/root#15927 (which I expect will be ignored, as it will open a can of worms).

PR validation:

Compiles, trivial technical change except that it does bump the ClassVersion.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45303/40710

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

• DataFormats/EcalDigi (simulation)

@mdhildreth, @cmsbuild, @civanch can you please review it and eventually sign? Thanks.
@ReyerBand, @wang0jin, @argiro, @rovere, @missirol, @mmusich, @thomreis, @rchatter this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[thomreis]

type ecal

[thomreis]

Hi @grasph can you please take a look at this PR and check that this change does not have unexpected consequences?

[grasph]

Hi @thomreis, the change is safe and should not have bad consequences.

[thomreis]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382e2b/40075/summary.html
COMMIT: 1085691
CMSSW: CMSSW_14_1_X_2024-06-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45303/40075/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345056
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1