Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overloaded book1DD method in DQMStore #45325

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 27, 2024

PR description:

This PR is a bugfix for the commit 0864545 introduced in #45225 (thanks to @rubenforti for spotting).

PR validation:

Run the unit tests (scram b runtests_testTrackingDATAMC) of the DQM/TrackingMonitorSource and looked at ME-s booked with the overloaded method and checked it is a TH1D indeed.

Screenshot from 2024-06-27 11-35-06

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported at #45315.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 27, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 27, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45325/40743

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQMServices/Core (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c0e02e/40118/summary.html
COMMIT: 207a6dc
CMSSW: CMSSW_14_1_X_2024-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45325/40118/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 14 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246767
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 3, 2024

a backport of this (#45315) was already merged. Why this is not signed yet?

@tjavaid
Copy link

tjavaid commented Jul 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5815534 into cms-sw:master Jul 3, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_fix_book1DD branch July 31, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants