Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double precision in StandaloneTrackMonitor and TrackTypeMonitor plots to avoid numerical overflow with high number of bin counts #45225

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 14, 2024

PR description:

The goal of this PR is to circumvent the issue reported at #45183.
In data/MC comparisons for tracking we were hit by the limits of TH1F numerical precision. Histograms with more than around 1e7 entries in a bin will stop accumulation in that bin (because within numerical precision x + 1. == x).
This PR changes the booking of StandaloneTrackMonitor and TrackTypeMonitor plots, from using book1D to book1DD in order to use double precision in bin content accumulation.
To limit the amount of changes in the tracking monitor classes a new overloaded book1DD method is added to DQMStore in order to be able to use the TH1D constructor of the type that creates a 1-Dim histogram with variable bins of type double:
TH1D (const char *name, const char *title, Int_t nbinsx, const Float_t *xbins)

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it might be backported for convenience if validation is positive.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45225/40592

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)
  • DQMServices/Core (dqm)

@rvenditti, @tjavaid, @cmsbuild, @nothingface0, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks.
@threus, @JanFSchulte, @VourMa, @VinInn, @mtosi, @sroychow, @arossi83, @idebruyn, @barvic, @mmusich, @fioriNTU, @jandrea this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 14, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee538c/39891/summary.html
COMMIT: 9a5f05b
CMSSW: CMSSW_14_1_X_2024-06-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45225/39891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3451538
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3451512
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Jun 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants