Fix maybe-uninitialized warning in SeedingTrackFeatures #45135

iarspider · 2024-06-04T14:01:10Z

PR description:

Fixes the following warnings:

src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc: In function 'seedingTracksToFeatures':
  src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].pt' may be used uninitialized [-Wmaybe-uninitialized]
   216 |         btagbtvdeep::SeedingTrackFeatures seed_features_zeropad;
      |                                           ^
  src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].eta' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].phi' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].mass' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].dz' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].dxy' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].ip3D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].sip3D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].ip2D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].sip2D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].signedIp3D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].signedSip3D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].signedIp2D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].signedSip2D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].trackProbability3D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].trackProbability2D' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].chi2reduced' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].nPixelHits' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].nHits' may be used uninitialized [-Wmaybe-uninitialized]
   src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].jetAxisDistance' may be used uninitialized [-Wmaybe-uninitialized]
 In member function '__ct ',
    inlined from 'construct_at' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_construct.h:97:14,
    inlined from 'construct' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/alloc_traits.h:518:21,
    inlined from 'push_back' at /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_vector.h:1281:30,
    inlined from 'seedingTracksToFeatures' at src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:218:43:
  src/DataFormats/BTauReco/interface/SeedingTrackFeatures.h:9:9: warning: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].jetAxisDlength' may be used uninitialized [-Wmaybe-uninitialized]
     9 |   class SeedingTrackFeatures {
      |         ^
src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc: In function 'seedingTracksToFeatures':
src/RecoBTag/FeatureTools/src/SeedingTracksConverter.cc:216:43: note: 'MEM[(const struct SeedingTrackFeatures &)&seed_features_zeropad].jetAxisDlength' was declared here
  216 |         btagbtvdeep::SeedingTrackFeatures seed_features_zeropad;
      |                                           ^

PR validation:

Bot tests

iarspider · 2024-06-04T14:01:21Z

please test for CMSSW_14_1_CPP20_X

cmsbuild · 2024-06-04T14:01:37Z

cms-bot internal usage

cmsbuild · 2024-06-04T14:08:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45135/40475

This PR adds an extra 20KB to repository

cmsbuild · 2024-06-04T14:08:22Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DataFormats/BTauReco (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Ming-Yan, @AlexDeMoor, @rovere, @demuller, @missirol, @castaned, @Senphy, @andrzejnovak this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-06-04T20:06:35Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87af01/39695/summary.html
COMMIT: 4fffa74
CMSSW: CMSSW_14_1_CPP20_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45135/39695/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87af01/39695/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87af01/39695/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

You potentially added 2424 lines to the logs
Reco comparison results: 127 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 908
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3337934
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2024-06-04T21:49:31Z

---> test RecoPPSLocalNewT2 had ERRORS

#45101

iarspider · 2024-06-04T21:49:54Z

please test

cmsbuild · 2024-06-05T00:41:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87af01/39701/summary.html
COMMIT: 4fffa74
CMSSW: CMSSW_14_1_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45135/39701/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338839
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-06-05T09:20:26Z

+1

cmsbuild · 2024-06-05T09:20:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2024-06-05T09:27:52Z

hold

looks like warnings are not fixed https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87af01/39695/build-logs/RecoBTag/FeatureTools/log.html

cmsbuild · 2024-06-05T09:28:11Z

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2024-06-06T08:21:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45135/40495

This PR adds an extra 16KB to repository

cmsbuild · 2024-06-06T08:22:03Z

Pull request #45135 was updated. @cmsbuild can you please check and sign again.

Fix maybe-uninitialized warning in SeedingTrackFeatures

4fffa74

cmsbuild added this to the CMSSW_14_1_X milestone Jun 4, 2024

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started code-checks-pending labels Jun 4, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 4, 2024

cmsbuild added tests-started and removed tests-rejected labels Jun 4, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 5, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jun 5, 2024

cmsbuild added pending-signatures hold and removed fully-signed labels Jun 5, 2024

iarspider closed this Jun 5, 2024

iarspider deleted the iarspider-patch-20240604-5 branch June 5, 2024 09:28

iarspider restored the iarspider-patch-20240604-5 branch June 6, 2024 08:08

iarspider reopened this Jun 6, 2024

Merge branch 'cms-sw:master' into iarspider-patch-20240604-5

dc22353

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 6, 2024

iarspider closed this Jun 6, 2024

iarspider deleted the iarspider-patch-20240604-5 branch June 6, 2024 08:15

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 6, 2024

iarspider mentioned this pull request Jun 6, 2024

Fix maybe-uninitialized warning in SeedingTrackFeatures #45152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix maybe-uninitialized warning in SeedingTrackFeatures #45135

Fix maybe-uninitialized warning in SeedingTrackFeatures #45135

iarspider commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024 •

edited

Loading

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

iarspider commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

jfernan2 commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

smuzaffar commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

Fix maybe-uninitialized warning in SeedingTrackFeatures #45135

Fix maybe-uninitialized warning in SeedingTrackFeatures #45135

Conversation

iarspider commented Jun 4, 2024

PR description:

PR validation:

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024 • edited Loading

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

Unit Tests

Comparison Summary

iarspider commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

Comparison Summary

jfernan2 commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

smuzaffar commented Jun 5, 2024

cmsbuild commented Jun 5, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 4, 2024 •

edited

Loading