Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LumiPixelsMinBias to Run1/2 Tier0Exp step #44787

Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Apr 19, 2024

PR description:

As noticed in #44780 , the path pathALCARECOLumiPixelsMinBias is defined in the step2 (RECO), but the path is not part the the process.schedule.

This PR adds LumiPixelsMinBias to the TIER0EXP and TIER0EXPRUN2 steps, as suggested by @makortel in #44780
See also #44780 (comment)

PR validation:

Run wfs 1001 and 1001.2 together with #44767, and the fatal exception reported in #44767 (comment) is not there any more

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

please test workflows 1001,1001.2 with #44767

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44787/40023

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @subirsarkar, @sunilUIET, @srimanob, @miquork can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @missirol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21edb3/38972/summary.html
COMMIT: bd31f44
CMSSW: CMSSW_14_1_X_2024-04-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44787/38972/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor Author

perrotta commented Apr 20, 2024

type bugfix

@perrotta
Copy link
Contributor Author

fixes #44780

@makortel
Copy link
Contributor

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please review and sign? Thanks!

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44767

@antoniovilela
Copy link
Contributor

This does not need to wait for #44767, correct?

@perrotta
Copy link
Contributor Author

This does not need to wait for #44767, correct?

Not at all!
That PR was only run together because it would have lead to crashes if the fix implemented here was not effective.

@antoniovilela
Copy link
Contributor

This does not need to wait for #44767, correct?

Not at all! That PR was only run together because it would have lead to crashes if the fix implemented here was not effective.

Thanks.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e3cae69 into cms-sw:master Apr 29, 2024
11 checks passed
@perrotta perrotta deleted the addLumiPixelsMinBiasToRun12Tier0Exp branch April 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants