[14_1_X] [Phase-2] Changed Phase-2 JME and BTV HLT paths to use the L1 P2GT emulator

[SohamBhattacharya]

This PR:

• Changes the Phase-2 JME and BTV HLT paths to use the L1 P2GT emulator.
  Now all Phase-2 paths use the P2GT emulator. No significant change is expected in the output.
  Testing on 100 events of [1], the trigger report for these paths is almost same before [2a] and after [2b] this change.

• Adds a seed (pDoublePuppiJet112_112) to the L1 abbreviated menu, which is needed by the dijet b-tagging HLT paths

• Cleans up HLT_75_e33_cff.py and HLT_75e33_timing_cff.py to stop running the P2GT emulator within the HLT config, as there is now a dedicated step (-L1P2GT) for that.

Tagging @cms-sw/l1-l2

[1] /store/relval/CMSSW_14_1_0_pre2/RelValSMS-T1tttt_14TeV/GEN-SIM-DIGI-RAW/140X_mcRun4_realistic_v3_STD_2026D98_noPU-v6/2580000/00cf94e1-2e9d-47cd-8c71-b699f7550858.root

[2a]

HLT-Report   HLT #  WasRun     L1S     Pre     HLT   %L1sPre    Rate  RateHi  Errors Name
HLT-Report      22     100     100     100      51  51.00000     0.0     0.0       0 HLT_AK4PFPuppiJet520
HLT-Report      23     100     100     100      77  77.00000     0.0     0.0       0 HLT_PFPuppiHT1070
HLT-Report      24     100     100     100      90  90.00000     0.0     0.0       0 HLT_PFPuppiMETTypeOne140_PFPuppiMHT140
HLT-Report      27     100     100     100      72  72.00000     0.0     0.0       0 HLT_PFHT330PT30_QuadPFPuppiJet_75_60_45_40_TriplePFPuppiBTagDeepCSV_2p4
HLT-Report      28     100     100     100      68  68.00000     0.0     0.0       0 HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepCSV_2p4
HLT-Report      29     100     100     100      43  43.00000     0.0     0.0       0 HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepCSV_2p4
HLT-Report      30     100     100     100      71  71.00000     0.0     0.0       0 HLT_PFHT330PT30_QuadPFPuppiJet_75_60_45_40_TriplePFPuppiBTagDeepFlavour_2p4
HLT-Report      31     100     100     100      70  70.00000     0.0     0.0       0 HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepFlavour_2p4
HLT-Report      32     100     100     100      78  78.00000     0.0     0.0       0 HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepFlavour_2p4

[2b]

HLT-Report   HLT #  WasRun     L1S     Pre     HLT   %L1sPre    Rate  RateHi  Errors Name
HLT-Report      23     100     100     100      51  51.00000     0.0     0.0       0 HLT_AK4PFPuppiJet520
HLT-Report      24     100     100     100      77  77.00000     0.0     0.0       0 HLT_PFPuppiHT1070
HLT-Report      25     100     100     100      92  92.00000     0.0     0.0       0 HLT_PFPuppiMETTypeOne140_PFPuppiMHT140
HLT-Report      28     100     100     100      72  72.00000     0.0     0.0       0 HLT_PFHT330PT30_QuadPFPuppiJet_75_60_45_40_TriplePFPuppiBTagDeepCSV_2p4
HLT-Report      29     100     100     100      68  68.00000     0.0     0.0       0 HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepCSV_2p4
HLT-Report      30     100     100     100      43  43.00000     0.0     0.0       0 HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepCSV_2p4
HLT-Report      31     100     100     100      71  71.00000     0.0     0.0       0 HLT_PFHT330PT30_QuadPFPuppiJet_75_60_45_40_TriplePFPuppiBTagDeepFlavour_2p4
HLT-Report      32     100     100     100      70  70.00000     0.0     0.0       0 HLT_PFHT200PT30_QuadPFPuppiJet_70_40_30_30_TriplePFPuppiBTagDeepFlavour_2p4
HLT-Report      33     100     100     100      78  78.00000     0.0     0.0       0 HLT_DoublePFPuppiJets128_DoublePFPuppiBTagDeepFlavour_2p4

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44751/39962

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44751/39962/cms-checkout-topic.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44751/39964

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @SohamBhattacharya for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• L1Trigger/Phase2L1GT (l1, upgrade)

@srimanob, @subirsarkar, @cmsbuild, @epalencia, @aloeliger, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@rovere, @Martin-Grunewald, @silviodonato, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@SohamBhattacharya please rebase the branch to avoid the merge commit. Also please add newlines to all the newly added files (there were recently PRs to add them to all files in cmssw).

[SohamBhattacharya]

@SohamBhattacharya please rebase the branch to avoid the merge commit. Also please add newlines to all the newly added files (there were recently PRs to add them to all files in cmssw).

Done.
For my own knowledge: is there a plan to include adding newlines to code-format? That would make it easier for the future.

[mmusich]

Done.

As far as I can see this was not rebased (at least I still see the merge commit). Please squash the commits.

For my own knowledge: is there a plan to include adding newlines to code-format? That would make it easier for the future.

AFAIR, some degree of python linting has been in the plans of the Core framework group, though I don't know about concrete steps about that.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44751/39966

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #44751 was updated. @Martin-Grunewald, @epalencia, @subirsarkar, @aloeliger, @srimanob, @mmusich, @cmsbuild can you please check and sign again.

[mmusich]

+hlt

[srimanob]

+Upgrade

[cmsbuild]

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with #44557, please check if they should be merged together

[mmusich]

@cms-sw/pdmv-l2 your signature is required here

[AdrianoDee]

please test

[mmusich]

there is a lot of comparison failures in wf 11634.0, which is a Run3 (2021) workflow and thus cannot be possibly affected in any way from this PR. In addition I have seen the same kind of comparison failures in more than one PR. I believe this workflow is experiencing some sort of intrinsic instability in the current IB.

just for the record, this was tracked in #44779

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e804a0/39147/summary.html
COMMIT: 7fb981f
CMSSW: CMSSW_14_1_X_2024-04-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44751/39147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 48 lines to the logs
• Reco comparison results: 129 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3326929
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3326909
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 204 log files, 166 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[AdrianoDee]

Tests were 2 weeks old, you never know.

[rappoccio]

+1