L1T P2: L1TrackVertexAssociationProducer bug fix to stop accessing data after move

[BenjaminRS]

PR description:

Currently when running L1TrackVertexAssociationProducer with a debug level of 2 or more the code will crash with a segfault as it is trying to access data in vTTTrackAssociatedOutput and vTTTrackAssociatedEmulationOutput which had just been moved in the preceding lines.

PR validation:

After moving the printDebugInfo command to before the move commands the module will run without crashing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a port of cms-l1t-offline#1231

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44601/39783

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @BenjaminRS for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (l1, upgrade)

@epalencia, @aloeliger, @subirsarkar, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160a76/38588/summary.html
COMMIT: 17203b8
CMSSW: CMSSW_14_1_X_2024-04-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44601/38588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 28 lines from the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3304819
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3304793
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

type bug-fix

[aloeliger]

+l1

[srimanob]

+Upgrade

Fix for debug-mode, no change is expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1