-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1TrackVertexAssociationProducer bug fix to stop accessing data after move #1231
L1TrackVertexAssociationProducer bug fix to stop accessing data after move #1231
Conversation
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 2 files that did not meet formatting requirements:
Please run
|
@BenjaminRS , can you fix the code-format issue? |
OK deleted the blank line: can we run the code format bot again please? |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 1 files that did not meet formatting requirements:
Please run
|
@BenjaminRS @epalencia I am going to go ahead and merge this. @BenjaminRS Could you please open a pull request for this to CMSSW as soon as possible. |
PR description:
Currently when running
L1TrackVertexAssociationProducer
with a debug level of 2 or more the code will crash with a segfault as it is trying to access data invTTTrackAssociatedOutput
andvTTTrackAssociatedEmulationOutput
which had just been moved in the preceding lines.PR validation:
After moving the printDebugInfo command to before the move commands the module will run without crashing.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR will need to be made to master too.