Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1TrackVertexAssociationProducer bug fix to stop accessing data after move #1231

Conversation

BenjaminRS
Copy link

@BenjaminRS BenjaminRS commented Mar 27, 2024

PR description:

Currently when running L1TrackVertexAssociationProducer with a debug level of 2 or more the code will crash with a segfault as it is trying to access data in vTTTrackAssociatedOutput and vTTTrackAssociatedEmulationOutput which had just been moved in the preceding lines.

PR validation:

After moving the printDebugInfo command to before the move commands the module will run without crashing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will need to be made to master too.

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 2 files that did not meet formatting requirements:

  • L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc
  • L1Trigger/L1TTrackMatch/plugins/L1TrackVertexAssociationProducer.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@epalencia
Copy link

@BenjaminRS , can you fix the code-format issue?

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR Bug fix For minor bug fixing PRs and removed Emulator Development Emulator development PR labels Apr 2, 2024
@BenjaminRS
Copy link
Author

OK deleted the blank line: can we run the code format bot again please?

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@aloeliger
Copy link

@BenjaminRS @epalencia I am going to go ahead and merge this. @BenjaminRS Could you please open a pull request for this to CMSSW as soon as possible.

@aloeliger aloeliger merged commit f57ef2b into cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix For minor bug fixing PRs Phase-2 Pertains to phase-2 development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants