Add missing newlines in Reconstruction modules

[fwyzard]

PR description:

Add missing newlines at the end of the files under

RecoBTag/Combined
RecoBTag/ImpactParameter
RecoBTag/PerformanceDB
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers
RecoLocalCalo/Configuration
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecProducers
RecoLocalTracker/Configuration
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripZeroSuppression
RecoLuminosity/LumiDB
RecoLuminosity/LumiProducer
RecoMTD/TrackExtender
RecoMuon/TrackerSeedGenerator
RecoMuon/TrackingTools

.

PR validation:

None.

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44246/39255

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParams.cc modified in PR(s): TOoLLiP integration #43638

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44246/39255/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44246/39255/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44246/39258

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParams.cc modified in PR(s): TOoLLiP integration #43638

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• RecoBTag/Combined (reconstruction)
• RecoBTag/ImpactParameter (reconstruction)
• RecoBTag/PerformanceDB (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoLocalCalo/Configuration (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
• RecoLocalTracker/Configuration (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoLocalTracker/SiStripClusterizer (reconstruction)
• RecoLocalTracker/SiStripZeroSuppression (reconstruction)
• RecoLuminosity/LumiDB (db)
• RecoLuminosity/LumiProducer (reconstruction)
• RecoMTD/TrackExtender (upgrade, reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)
• RecoMuon/TrackingTools (reconstruction)

@jfernan2, @perrotta, @srimanob, @mandrenguyen, @consuegs, @subirsarkar, @francescobrivio, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@emilbols, @gpetruc, @Fedespring, @JyothsnaKomaragiri, @yuanchao, @lgray, @andrzejnovak, @threus, @mtosi, @ram1123, @jlidrych, @VinInn, @jainshilpi, @sethzenz, @andrea21z, @gbenelli, @GiacomoSguazzoni, @vandreev11, @bsunanda, @Prasant1993, @ferencek, @demuller, @jhgoh, @varuns23, @rovere, @pfs, @CeliaFernandez, @lecriste, @VourMa, @argiro, @felicepantaleo, @bellan, @fabiocos, @rociovilar, @AlexDeMoor, @ReyerBand, @sobhatta, @dkotlins, @rchatter, @cseez, @sameasy, @HuguesBrun, @trocino, @mroguljic, @Ming-Yan, @AnnikaStein, @missirol, @yduhm, @mmusich, @rsreds, @alesaggio, @hatakeyamak, @apsallid, @a-kapoor, @thomreis, @afiqaize, @echabert, @abbiendi, @JanFSchulte, @cericeci, @valsdav, @edjtscott, @wang0jin, @Sam-Harper, @youyingli, @Senphy, @tvami, @robervalwalsh, @PonIlya this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c14543/37773/summary.html
COMMIT: b03b1e9
CMSSW: CMSSW_14_1_X_2024-02-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44246/37773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 104 lines from the logs
• Reco comparison results: 64 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3011576
• DQMHistoTests: Total failures: 1198
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3010356
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+db

[jfernan2]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1