Fix some minor RooFit user errors

[guitargeek]

• One should use getVal() and not getValV() (the latter should not be called. The "V" stands for virtual, and getValV() is the function that should be overridden if one wants to change the behavior of getVal())

• Avoid some memory leaks by not creating a leaking fit result by using the Save() option

• Improve memory management with smart pointers

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44069/39027

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/EGamma/plugins/PhotonDataCertification.cc modified in PR(s): Avoid fitting empy histograms in PhotonDataCertification #44064

[cmsbuild]

A new Pull Request was created by @guitargeek for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• DQMOffline/Alignment (dqm)
• DQMOffline/EGamma (dqm)
• MuonAnalysis/MomentumScaleCalibration (alca)
• PhysicsTools/TagAndProbe (analysis)
• Validation/MtdValidation (dqm)

@nothingface0, @syuvivida, @tvami, @consuegs, @antoniovagnerini, @perrotta, @cmsbuild, @tjavaid, @rvenditti, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @tocheng, @argiro, @ReyerBand, @bellan, @thomreis, @mmusich, @rchatter, @missirol, @tlampen, @fabiocos, @rociovilar, @JanFSchulte, @rovere, @rsreds, @wang0jin, @adewit this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[mmusich]

nothing happened in the last 13 hours... let's try again

[mmusich]

@cmsbuild, please abort

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3444e0/37659/summary.html
COMMIT: 8b155b3
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44069/37659/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 91 lines to the logs
• Reco comparison results: 58 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 1189
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244154
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[tjavaid]

+1

• spurious differences seen from unstable WF 12434.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44069/39282

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/TagAndProbe/src/TagProbeFitter.cc modified in PR(s): TOoLLiP integration #43638
  • File Validation/MtdValidation/macros/Pt_residuals_fit.C modified in PR(s): TOoLLiP integration #43638

[cmsbuild]

Pull request #44069 was updated. @antoniovagnerini, @perrotta, @tjavaid, @rvenditti, @tvami, @consuegs, @cmsbuild, @saumyaphor4252, @syuvivida, @nothingface0 can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3444e0/37811/summary.html
COMMIT: cb9c4e5
CMSSW: CMSSW_14_1_X_2024-02-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44069/37811/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @wddgit Delete function warnAboutLegacyModules (no longer needed) #44254
• @mmusich add failsafes for protecting the alpaka customization against Fake HLT menus #44221
• @fwyzard Add missing newlines in TBDataFormats modules #44248
• @mmusich Tracker alignment offline validation tools: miscellaneous fixes to muon-related validations #44252
• @brusale Add FlatPtGeneration to CloseByParticleGun #44008
• @theochatzis Jet phi variable in L1 correction #44084
• @mbluj Refactoring of Phase1 OMTF emulator code #43687
• @fwyzard Add missing newlines in Analysis modules #44224
• @fwyzard Add missing newlines in Reconstruction modules #44246
• @fwyzard Add missing newlines in PhysicsTools modules #44245
• @jmduarte Add Phase-2 Level-1 trigger ML MET emulator #43633
• @jsamudio Remove unnecessary ESProducer from LegacyPFClusterProducer #44070
• @bsunanda Run3-gex176A update the cfg files in SimG4Core/PrintGeomInfo to access the new scenario #44037
• @wddgit Improve ExternalGeneratorFilter to handle a stream skipping a lumi #43783
• @wddgit Migrate away from OwnVector<TrackingRegion> #44063
• @wddgit Migrate away from OwnVector<BaseTrackerRecHit> #44047
• @mseidel42 Adapt ParticleLevelProducer for Rivet 3.1.10 #43973
• @makortel Erase from correct vector in PATTauHybridProducer #44067
• @chnielse Adding Phase 2 HPS Tau Emulator #43848
• @bsunanda Run3-gex176E Update the rpc geometry description for 2024 scenario #44093

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3444e0/37811/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3444e0/37811/git-merge-result

Comparison Summary

Summary:

• You potentially added 94 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3338784
• DQMHistoTests: Total failures: 68
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338694
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• re-sign

[perrotta]

+alca

• re-sign

[tjavaid]

+1

• re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1