Print the labels of ConditionalTask modules that are not consumed in any of the associated Paths

[makortel]

PR description:

The original goal was to delete such modules from the job (similarly to non-consumed unscheduled modules), but that turned out to be complicated (as there could be modules that should be treated like this that are consumed by some other module). Printing out the labels should suffice the remaining HLT needs for ConditionalTask.

Resolves cms-sw/framework-team#712

PR validation:

Framework unit tests run.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43296/37720

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• FWCore/Framework (core)

@Dr15Jones, @cmsbuild, @smuzaffar, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@Dr15Jones Could you review?

[makortel]

FYI @rovere

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f44fa/35864/summary.html
COMMIT: e5c6296
CMSSW: CMSSW_14_0_X_2023-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43296/35864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 612 lines to the logs
• Reco comparison results: 134 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363070
• DQMHistoTests: Total failures: 1910
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361138
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

Addressed Chris' comments

[makortel]

Ok, thanks @mmusich @rovere

(the last update just removed one unnecessary newline from the printout)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43296/37787

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #43296 was updated. @cmsbuild, @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f44fa/35966/summary.html
COMMIT: 725f03d
CMSSW: CMSSW_14_0_X_2023-11-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43296/35966/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1020 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363868
• DQMHistoTests: Total failures: 1397
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362449
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

Usual set of non-reproducibilities of #39803 and #43293

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1