Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting the Phase-2 HLT menu to not use Tasks #42940

Closed
mmusich opened this issue Oct 4, 2023 · 11 comments
Closed

Reverting the Phase-2 HLT menu to not use Tasks #42940

mmusich opened this issue Oct 4, 2023 · 11 comments

Comments

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2023

In #42934 (comment) it was suggested to consider reverting the Phase-2 HLT menu to not use Tasks to avoid triggering undesired unscheduled execution of EDProducers.
The 14_0_X cycle was agreed to be a reasonable target to achieve this (see #42934 (comment)).

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2023

assign hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

New categories assigned: hlt

@Martin-Grunewald,@mmusich,@missirol you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

A new Issue was created by @mmusich Marco Musich.

@rappoccio, @antoniovilela, @smuzaffar, @Dr15Jones, @sextonkennedy, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 4, 2023

@rovere @SohamBhattacharya FYI

@makortel
Copy link
Contributor

makortel commented Oct 4, 2023

Just to bring up one option (now that I have some brain bandwidth again), following the discussion in #36938, a ConditionalTask was added in the configuration system. It is similar to Task that it is an unordered collection of EDProducers, but differs such that the ConditionalTask adds the modules in the ConditionalTask to the associated Path in the proper order based on consumes/produces calls of the modules in the Path and in the ConditionalTask. Those modules will then behave as if they were part of the scheduled system (well, in a sense they are), i.e. their execution is dictated only by the EDFilters preceding them in the Path.

There is one caveat though: the modules in ConditionalTask that are not consumed by any other module in the Path, or in the ConditionalTasks associated with the Path, are treated as unscheduled modules (i.e. any other module consuming their data products will cause them to run). Changing the behavior such that those modules would not get run (e.g. by removing them from the job, as is done for any non-consumed unscheduled module already) is in our radar, but we wanted to see first how the ConditionalTask gets used in the HLT (especially if it is still needed after moving from "SwitchProducer with CUDA+legacy modules" towards "module type resolver with Alpaka modules").

If organizing the modules in Task-like way would still be beneficial, maybe it would be worth of trying out ConditionalTask?

@makortel
Copy link
Contributor

#43296 implements the printout of ConditionalTask modules that are not consumed by any module in any of the Paths the ConditionalTask (in question) is associated with, as discussed with some of the HLT folks.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 20, 2024

IIUC #44025 starts to implement things in this direction.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 5, 2024

#44604 completes the migration of the phase-2 HLT menu to use sequences.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 8, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

This issue is fully signed and ready to be closed.

@makortel
Copy link
Contributor

makortel commented Apr 8, 2024

@cmsbuild, please close

@cmsbuild cmsbuild closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants