Herwig lhe matching fix 12_4 #42906
Herwig lhe matching fix 12_4 #42906
Conversation
…g events Read lhe event numbers in, if present Add HadroniserFilter to Herwig which correctly matches LHE numbers between CMSSW and herwig Add option to Herwig input fragements to use LHE numbering Change test examples to use new HadroniserFilter+ LHE numbering code style code style Call addLHEnumbers from mergeLHE.py if asked to number events and not using the DefaultLHEMerger Number events before merge (so numbers are also available to LHEReader) Include evtnum in LHEEventProduct (necesary for multithreading)
|
A new Pull Request was created by @Dominic-Stafford for CMSSW_12_4_X. It involves the following packages:
@mkirsano, @GurpreetSinghChahal, @menglu21, @cmsbuild, @SiewYan, @bbilin, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
backport of #42673 |
|
please test with cms-sw/cmsdist#8729 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff0c56/35069/summary.html Comparison SummarySummary:
|
| @@ -5,6 +5,7 @@ | |||
| "CosMuoGenProducer", | |||
| "ExhumeGeneratorFilter", | |||
| "Herwig7GeneratorFilter", | |||
| "Herwig7HadronizerFilter", | |||
There was a problem hiding this comment.
@Dominic-Stafford this file is not in the master branch
There was a problem hiding this comment.
Hi Meng, this file is in master (and all releases since CMSSW_12). This line is the one change in #42732 as proposed here: #42673 (comment)
|
ping @cms-sw/generators-l2 |
|
+1 |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Backport of #42673 and #42732 for use in 2022 gen production. These add a new Herwig7HadronizerFilter, designed to resolve the issue of the wrong lhe events being saved with Herwig.
Should be tested with cms-sw/cmsdist#8729