Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Add patches to propagate lhe numbering through herwig #8729

Conversation

Dominic-Stafford
Copy link
Contributor

Backport of #8670 for use in 2022 production. Adds patches which propagate an event number provided in an LHE file through Herwig, which is necessary for ensuring the lhe events "line up" with the gen events if some events are skipped in merging.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2023

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#42906

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f48dde/34969/summary.html
COMMIT: 9669b1a
CMSSW: CMSSW_12_4_X_2023-09-24-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8729/34969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the title Add patches to propagate lhe numbering through herwig [12.4.X] Add patches to propagate lhe numbering through herwig Sep 29, 2023
@smuzaffar
Copy link
Contributor

backport of #8670

@smuzaffar
Copy link
Contributor

smuzaffar commented Sep 29, 2023

+externals

@rappoccio @antoniovilela , feel free to merge it for next 12.4.X release.
This should go in along with cms-sw/cmssw#42906

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit 02f1e19 into cms-sw:IB/CMSSW_12_4_X/master Oct 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants