Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT #42707

Merged
merged 1 commit into from
Sep 4, 2023
Merged

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT #42707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DataFormats/HLTReco/interface/TriggerTypeDefs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ namespace trigger {
TriggerL1Vertex = -124,
// Phase-1: MuonShower
TriggerL1MuShower = -125, // stage2 (introduced in Run 3)
// Phase-1: ZDC+ and ZDC-
TriggerL1ZDCP = -126, // stage2 (introduced in 2023 during Run 3)
TriggerL1ZDCM = -127, // stage2 (introduced in 2023 during Run 3)

/// HLT
TriggerPhoton = +81,
Expand Down
87 changes: 87 additions & 0 deletions HLTrigger/HLTfilters/plugins/HLTL1TSeed.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ HLTL1TSeed::HLTL1TSeed(const edm::ParameterSet& parSet)
m_l1EtSumCollectionsTag(parSet.getParameter<edm::InputTag>("L1EtSumInputTag")), // FIX WHEN UNPACKERS ADDED
m_l1EtSumTag(m_l1EtSumCollectionsTag),
m_l1EtSumToken(consumes<l1t::EtSumBxCollection>(m_l1EtSumTag)),
m_l1EtSumZdcCollectionsTag(parSet.getParameter<edm::InputTag>("L1EtSumZdcInputTag")), // FIX WHEN UNPACKERS ADDED
m_l1EtSumZdcTag(m_l1EtSumZdcCollectionsTag),
m_l1EtSumZdcToken(consumes<l1t::EtSumBxCollection>(m_l1EtSumZdcTag)),
m_l1GlobalDecision(false),
m_isDebugEnabled(edm::isDebugEnabled()) {
if (m_l1SeedsLogicalExpression.empty()) {
Expand Down Expand Up @@ -104,6 +107,7 @@ void HLTL1TSeed::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
desc.add<edm::InputTag>("L1JetInputTag", edm::InputTag("hltGtStage2Digis:Jet"));
desc.add<edm::InputTag>("L1TauInputTag", edm::InputTag("hltGtStage2Digis:Tau"));
desc.add<edm::InputTag>("L1EtSumInputTag", edm::InputTag("hltGtStage2Digis:EtSum"));
desc.add<edm::InputTag>("L1EtSumZdcInputTag", edm::InputTag("hltGtStage2Digis:EtSumZDC"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope L1T is using that label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For L1EtSumZdcInputTag, I kept Zdc as in the parameters of L1TGlobalProducer (#42634). And yes, for :EtSumZDC I plan to ask that they use this name when they update L1TRawToDigi (unpacker).

descriptions.add("hltL1TSeed", desc);
}

Expand Down Expand Up @@ -131,6 +135,9 @@ bool HLTL1TSeed::hltFilter(edm::Event& iEvent,

// etsum
filterproduct.addCollectionTag(m_l1EtSumTag);

// etsum (ZDC)
filterproduct.addCollectionTag(m_l1EtSumZdcTag);
}

// Get all the seeding from iEvent (i.e. L1TriggerObjectMapRecord)
Expand Down Expand Up @@ -423,6 +430,36 @@ void HLTL1TSeed::dumpTriggerFilterObjectWithRefs(trigger::TriggerFilterObjectWit
LogTrace("HLTL1TSeed") << "\tL1EtSum AsymHtHF: hwPt = " << obj->hwPt();
}

vector<l1t::EtSumRef> seedsL1EtSumZDCP;
filterproduct.getObjects(trigger::TriggerL1ZDCP, seedsL1EtSumZDCP);
const size_t sizeSeedsL1EtSumZDCP = seedsL1EtSumZDCP.size();
LogTrace("HLTL1TSeed") << "\n L1EtSum ZDCP seeds: " << sizeSeedsL1EtSumZDCP << endl << endl;

for (size_t i = 0; i != sizeSeedsL1EtSumZDCP; i++) {
l1t::EtSumRef obj = l1t::EtSumRef(seedsL1EtSumZDCP[i]);

LogTrace("HLTL1TSeed") << "\tL1EtSum ZDCP"
<< "\t"
<< "pt = " << obj->pt() << "\t"
<< "eta = " << obj->eta() << "\t"
<< "phi = " << obj->phi(); //<< "\t" << "BX = " << obj->bx();
}

vector<l1t::EtSumRef> seedsL1EtSumZDCM;
filterproduct.getObjects(trigger::TriggerL1ZDCM, seedsL1EtSumZDCM);
const size_t sizeSeedsL1EtSumZDCM = seedsL1EtSumZDCM.size();
LogTrace("HLTL1TSeed") << "\n L1EtSum ZDCM seeds: " << sizeSeedsL1EtSumZDCM << endl << endl;

for (size_t i = 0; i != sizeSeedsL1EtSumZDCM; i++) {
l1t::EtSumRef obj = l1t::EtSumRef(seedsL1EtSumZDCM[i]);

LogTrace("HLTL1TSeed") << "\tL1EtSum ZDCM"
<< "\t"
<< "pt = " << obj->pt() << "\t"
<< "eta = " << obj->eta() << "\t"
<< "phi = " << obj->phi(); //<< "\t" << "BX = " << obj->bx();
}

LogTrace("HLTL1TSeed") << " \n\n" << endl;
}

Expand Down Expand Up @@ -463,6 +500,8 @@ bool HLTL1TSeed::seedsL1TriggerObjectMaps(edm::Event& iEvent, trigger::TriggerFi
std::list<int> listAsymHt;
std::list<int> listAsymEtHF;
std::list<int> listAsymHtHF;
std::list<int> listZDCP;
std::list<int> listZDCM;

// get handle to unpacked GT
edm::Handle<GlobalAlgBlkBxCollection> uGtAlgoBlocks;
Expand Down Expand Up @@ -780,6 +819,12 @@ bool HLTL1TSeed::seedsL1TriggerObjectMaps(edm::Event& iEvent, trigger::TriggerFi
case l1t::gtAsymmetryHtHF: {
listAsymHtHF.push_back(*itObject);
} break;
case l1t::gtZDCP: {
listZDCP.push_back(*itObject);
} break;
case l1t::gtZDCM: {
listZDCM.push_back(*itObject);
} break;
case l1t::gtCentrality0:
case l1t::gtCentrality1:
case l1t::gtCentrality2:
Expand Down Expand Up @@ -885,6 +930,12 @@ bool HLTL1TSeed::seedsL1TriggerObjectMaps(edm::Event& iEvent, trigger::TriggerFi
listAsymHtHF.sort();
listAsymHtHF.unique();

listZDCP.sort();
listZDCP.unique();

listZDCM.sort();
listZDCM.unique();

// record the L1 physics objects in the HLT filterproduct
// //////////////////////////////////////////////////////

Expand Down Expand Up @@ -1075,6 +1126,42 @@ bool HLTL1TSeed::seedsL1TriggerObjectMaps(edm::Event& iEvent, trigger::TriggerFi

} // end else

// ZDCP, ZDCM
edm::Handle<l1t::EtSumBxCollection> etsumzdcs;
iEvent.getByToken(m_l1EtSumZdcToken, etsumzdcs);
if (!etsumzdcs.isValid()) {
//!! FIXME: replace LogDebug with edm::LogWarning once unpacker of ZDC inputs to L1-uGT becomes available
//!! https://github.com/cms-sw/cmssw/pull/42634#issuecomment-1698132805
//!! https://github.com/cms-sw/cmssw/blob/bece38936ef0ba111f4b5f4502e819595560afa6/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTSetup.cc#L76
LogDebug("HLTL1TSeed") << "\nWarning: L1EtSumBxCollection with input tag " << m_l1EtSumZdcTag
<< "\nrequested in configuration, but not found in the event."
<< "\nNo etsums (ZDC) added to filterproduct.";
} else {
l1t::EtSumBxCollection::const_iterator iter;

for (iter = etsumzdcs->begin(0); iter != etsumzdcs->end(0); ++iter) {
l1t::EtSumRef myref(etsumzdcs, etsumzdcs->key(iter));

switch (iter->getType()) {
case l1t::EtSum::kZDCP:
if (!listZDCP.empty())
filterproduct.addObject(trigger::TriggerL1ZDCP, myref);
break;
case l1t::EtSum::kZDCM:
if (!listZDCM.empty())
filterproduct.addObject(trigger::TriggerL1ZDCM, myref);
break;
default:
LogTrace("HLTL1TSeed")
<< " L1EtSum (ZDC) seed of currently unsuported HLT TriggerType. l1t::EtSum type: "
<< iter->getType() << "\n";

} // end switch

} // end for

} // end else

// TODO FIXME uncomment if block when JetCounts implemented

// // jet counts
Expand Down
11 changes: 8 additions & 3 deletions HLTrigger/HLTfilters/plugins/HLTL1TSeed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,21 +120,26 @@ class HLTL1TSeed : public HLTStreamFilter {
edm::InputTag m_l1EGammaTag;
edm::EDGetTokenT<l1t::EGammaBxCollection> m_l1EGammaToken;

/// Meta InputTag for L1 Egamma collection
/// Meta InputTag for L1 Jet collection
edm::InputTag m_l1JetCollectionsTag;
edm::InputTag m_l1JetTag;
edm::EDGetTokenT<l1t::JetBxCollection> m_l1JetToken;

/// Meta InputTag for L1 Egamma collection
/// Meta InputTag for L1 Tau collection
edm::InputTag m_l1TauCollectionsTag;
edm::InputTag m_l1TauTag;
edm::EDGetTokenT<l1t::TauBxCollection> m_l1TauToken;

/// Meta InputTag for L1 Egamma collection
/// Meta InputTag for L1 EtSum collection
edm::InputTag m_l1EtSumCollectionsTag;
edm::InputTag m_l1EtSumTag;
edm::EDGetTokenT<l1t::EtSumBxCollection> m_l1EtSumToken;

/// Meta InputTag for L1 EtSum (ZDC) collection
edm::InputTag m_l1EtSumZdcCollectionsTag;
edm::InputTag m_l1EtSumZdcTag;
edm::EDGetTokenT<l1t::EtSumBxCollection> m_l1EtSumZdcToken;

/// flag to pass if L1TGlobal accept
bool m_l1GlobalDecision;

Expand Down