add support for L1T `EtSum`s of type `kZDC{P,M}` as trigger objects at HLT #42707

missirol · 2023-09-02T07:57:51Z

PR description:

This PR adds support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT. These new types were introduced in #42634 (L1T-ZDC emulation).

Two types, trigger::TriggerL1ZDC{P,M}, are added to TriggerTypeDefs.h, and support for them is added to the plugin HLTL1TSeed (which puts L1T objects into the edm::Event as part of the TriggerFilterObjectWithRefs data format).

A similar update was done in #36951 to support the L1T data formats for "MuonShowers". One difference in this PR is that the underlying data format, i.e. l1t::EtSum, is not a new one (unlike l1t::MuonShower was), and this makes the changes on the HLT side less extensive compared to #36951.

Note: the edm::InputTag added to HLTL1TSeed in this PR will point to a non-existing collection in the current HLT menus until an unpacker for the ZDC inputs to the L1T-uGT is added to CMSSW (see #42634 (comment)). For this reason, only a LogDebug message is issued when this collection is missing, and eventually this should be replaced by a edm::LogWarning (once the unpacker is available).

No changes expected.

PR validation:

addOnTests.py passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_2_X

cmsbuild · 2023-09-02T08:09:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42707/36800

This PR adds an extra 28KB to repository

cmsbuild · 2023-09-02T08:10:12Z

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

DataFormats/HLTReco (hlt)
HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

missirol · 2023-09-02T08:11:04Z

urgent

Because of #42708 (comment).

missirol · 2023-09-02T08:11:23Z

please test

cmsbuild · 2023-09-02T16:31:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0de4f/34585/summary.html
COMMIT: 8503a89
CMSSW: CMSSW_13_3_X_2023-09-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42707/34585/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 164 lines from the logs
Reco comparison results: 356 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153350
DQMHistoTests: Total failures: 346
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3152982
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

missirol · 2023-09-02T17:41:21Z

You potentially removed 164 lines from the logs
Reco comparison results: 356 differences found in the comparisons

The DQM differences in the outputs of PR tests seem compatible with #39803, #39754 and #42525.

I will relaunch the tests (now with a different IB as baseline) to verify that there are no DQM differences due to this PR.

missirol · 2023-09-02T17:41:28Z

please test

cmsbuild · 2023-09-02T21:01:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0de4f/34586/summary.html
COMMIT: 8503a89
CMSSW: CMSSW_13_3_X_2023-09-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42707/34586/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 26 lines to the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153350
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153322
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

missirol · 2023-09-03T07:15:39Z

No DQM differences due to this PR in the latest round of tests, as expected.

Martin-Grunewald · 2023-09-04T06:39:34Z

HLTrigger/HLTfilters/plugins/HLTL1TSeed.cc

@@ -104,6 +107,7 @@ void HLTL1TSeed::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
  desc.add<edm::InputTag>("L1JetInputTag", edm::InputTag("hltGtStage2Digis:Jet"));
  desc.add<edm::InputTag>("L1TauInputTag", edm::InputTag("hltGtStage2Digis:Tau"));
  desc.add<edm::InputTag>("L1EtSumInputTag", edm::InputTag("hltGtStage2Digis:EtSum"));
+  desc.add<edm::InputTag>("L1EtSumZdcInputTag", edm::InputTag("hltGtStage2Digis:EtSumZDC"));


Let's hope L1T is using that label.

For L1EtSumZdcInputTag, I kept Zdc as in the parameters of L1TGlobalProducer (#42634). And yes, for :EtSumZDC I plan to ask that they use this name when they update L1TRawToDigi (unpacker).

Martin-Grunewald · 2023-09-04T07:29:44Z

+1

cmsbuild · 2023-09-04T07:30:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2023-09-04T15:31:36Z

+1

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT

8503a89

cmsbuild added this to the CMSSW_13_3_X milestone Sep 2, 2023

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 2, 2023

missirol mentioned this pull request Sep 2, 2023

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT [13_2_X] #42708

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 2, 2023

cmsbuild added the urgent label Sep 2, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 2, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 2, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 2, 2023

This was referenced Sep 2, 2023

Non-reproducibility in JetMET/{Jet,MET}Validation histograms in phase2 workflows #39754

Open

Spurious DQM differences in MVA-related quantities (tensorflow related ?) #42525

Open

spurious differences in outputs of Run-3 wfs *.7 #39803

Open

cmsbuild added tests-approved and removed tests-started labels Sep 2, 2023

Martin-Grunewald reviewed Sep 4, 2023

View reviewed changes

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Sep 4, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 4, 2023

cmsbuild merged commit 5b4fe36 into cms-sw:master Sep 4, 2023
1 check passed

missirol deleted the devel_hltL1TSeedEtSumZDC branch September 4, 2023 16:23

missirol mentioned this pull request Sep 6, 2023

Adding ZDC Unpacker to L1RawtoDigi #42733

Merged

mmusich mentioned this pull request Jun 25, 2024

Updates to include HTMHF triggers in GT emulator #45295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for L1T `EtSum`s of type `kZDC{P,M}` as trigger objects at HLT #42707

add support for L1T `EtSum`s of type `kZDC{P,M}` as trigger objects at HLT #42707

missirol commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

missirol commented Sep 2, 2023

missirol commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

missirol commented Sep 2, 2023 •

edited

Loading

missirol commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

missirol commented Sep 3, 2023

Martin-Grunewald Sep 4, 2023

missirol Sep 4, 2023

Martin-Grunewald commented Sep 4, 2023

cmsbuild commented Sep 4, 2023

antoniovilela commented Sep 4, 2023

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT #42707

add support for L1T EtSums of type kZDC{P,M} as trigger objects at HLT #42707

Conversation

missirol commented Sep 2, 2023

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

missirol commented Sep 2, 2023

missirol commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

Comparison Summary

missirol commented Sep 2, 2023 • edited Loading

missirol commented Sep 2, 2023

cmsbuild commented Sep 2, 2023

Comparison Summary

missirol commented Sep 3, 2023

Martin-Grunewald Sep 4, 2023

Choose a reason for hiding this comment

missirol Sep 4, 2023

Choose a reason for hiding this comment

Martin-Grunewald commented Sep 4, 2023

cmsbuild commented Sep 4, 2023

antoniovilela commented Sep 4, 2023

add support for L1T `EtSum`s of type `kZDC{P,M}` as trigger objects at HLT #42707

add support for L1T `EtSum`s of type `kZDC{P,M}` as trigger objects at HLT #42707

missirol commented Sep 2, 2023 •

edited

Loading