Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 132X data and MC GTs #42551

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add 132X data and MC GTs #42551

merged 1 commit into from
Aug 15, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR adds to the release the 132X GTs for data and for Run 3 MC.
There are a few conditions updated, namely:

  • Added the new LHCInfoPerLS and LHCInfoPerLS tags (see this CMSTalk post) required by the PPS reco changes in PR CTPPS reco update to use LHCInfoPer* records #42515
    • Tags for Prompt:
      • LHCInfoPerLS_endFill_Run3_v1
      • LHCInfoPerFill_endFill_Run3_v1
    • Tags for MC:
      • LHCInfoPerLS_endFill_Run3_mc_v1
      • LHCInfoPerFill_endFill_Run3_mc_v1
    • Tags for HLT/Express (single-IOV "null" tags for the moment, in view of future developments):
      • LHCInfoPerLS_hlt_forPPS
      • LHCInfoPerFill_hlt_forPPS
  • Updated the ZDC reco geometry tags requested in this CMSTalk post
    • For 2022 MC: ZDCRECO_Geometry_132DD4hepV2
    • For 2023 MC: ZDCRECO_Geometry_132DD4hepV3
  • Updated SiPixelDynIneff tag to SiPixelDynamicInefficiency_phase1_2023_v2_fix3 requested:
  • Updated SiPixel BadComponents tags for 2022 MC as requested in this CMSTalkPost:
    • pre-EE leak:
      • SiPixelQuality_phase1_2022_v2b_mc
      • SiPixelQuality_forDigitizer_phase1_2022_v2b_mc
    • post-EE leak:
      • SiPixelQuality_phase1_2022_v5_mc
      • SiPixelQuality_forDigitizer_phase1_2022_v5_mc

Additionally, the 132X online GTs contain the updates detailed in this CMSTalk post:

GT Differences

PR validation:

Validated running:

runTheMatrix.py -l 159.0,160.0,12034.0,12434.0,12834.0,11601.0,138.4,138.5,139.001 -j 8 --ibeos

on top of PR #42515. Workflows crash without the updated GTs, while the finish successfully with the new 132X GTs.

Backport:

Not a backport, but a 13_2_X backport will be opened soon

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Aug 11, 2023
@francescobrivio francescobrivio mentioned this pull request Aug 11, 2023
Merged
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio francescobrivio mentioned this pull request Aug 11, 2023
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42551/36567

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90f1fd/34246/summary.html
COMMIT: d745407
CMSSW: CMSSW_13_3_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42551/34246/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 2523 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 15672
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3135253
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

I think the many differences are expected from the redigitization using new SiPixelDynEff payload.

@francescobrivio francescobrivio mentioned this pull request Aug 12, 2023
Open
@consuegs consuegs mentioned this pull request Aug 14, 2023
Merged
@tvami
Copy link
Contributor

tvami commented Aug 14, 2023

+alca

  • tests pass
  • PR in line with description
  • lot of diff in plots but that's expected from the GT change

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 788fdd0 into cms-sw:master Aug 15, 2023
@cmsbuild cmsbuild mentioned this pull request Aug 15, 2023
Closed
@saumyaphor4252 saumyaphor4252 mentioned this pull request Aug 18, 2023
Merged
@slava77
Copy link
Contributor

slava77 commented Aug 18, 2023

looking at postBpix vs 2024 GT, it looks like the 2024 is a bit "old". Is there a plan perhaps to update 2024 to look more like the end of 2023?

@saumyaphor4252
Copy link
Contributor

looking at postBpix vs 2024 GT, it looks like the 2024 is a bit "old". Is there a plan perhaps to update 2024 to look more like the end of 2023?

@slava77
The 2024(and the 2023 too) GT keys were originally created back in 2019 for projections for the last two years of Run2. So the origin of this huge diff in the 2024 GT can be traced back to that.

The 2024 GT in principle will mainly become important for next year when we will have a corresponding MC campaign, and the plan is to update this GT then after review and official sign-off for the conditions from all the subsystems, similar to 2023.

Just to mention, there was also a similar discussion for these differences in the 2022-2023 GTs last year in [1].

[1] https://cms-talk.web.cern.ch/t/question-about-mcrun3-2023-2024-conditions/21268

@mmusich
Copy link
Contributor

mmusich commented Aug 18, 2023 •
edited
Loading

@saumyaphor4252

The 2024 GT in principle will mainly become important for next year when we will have a corresponding MC campaign, and the plan is to update this GT then after review and official sign-off for the conditions from all the subsystems, similar to 2023.

there are certain applications in which you want the "2019" pessimistic projection for radiation damage, but you still want to have realistic bad components. I think an update of the 2024 GT key is in order to reflect at least the current status of the detector at P5.

@saumyaphor4252
Copy link
Contributor

I think an update of the 2024 GT key is in order to reflect at least the current status of the detector at P5.

Okay, we'll follow up on this soon.

@francescobrivio francescobrivio deleted the alca-add_132X_GTs branch November 20, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
7 participants
@francescobrivio @cmsbuild @tvami @perrotta @slava77 @saumyaphor4252 @mmusich