Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chaining in rules and unify prefix and rules of protocols #42529

Closed
wants to merge 35 commits into from

Conversation

nhduongvn
Copy link
Contributor

The chaining mechanism is still be supported in the new storage description as in the case of Trivial File Catalogue (TFC) before:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/StorageDescription
However, it was effectively turned off (chain="") during development of codes for the new storage description
#37278
Therefore, some sites will not see the files, for example T2_DE_DESY
https://cms-talk.web.cern.ch/t/errors-of-missing-files-at-t2-de-desy/27838/20
(currently there are three sites use 'chain' T1_DE_KIT, T2_DE_DESY, T2_BE_IIHE.)

This PR puts back the chaining feature. It also unifies the prefix and rules of protocols by converting the prefix to a rule. Therefore, codes handling prefix and rules are the same.

rselvati and others added 30 commits July 18, 2023 16:59
Update electron IDs in HLT Offline DQM [`13_2_X`]
…allback_logic

[13_2_X] Revert BeamSpot fallback logic
…sourcing_13_2_X

[13_2_X] Improve discover method in cond2xml for read-only and patch releases
[13_2_x] PPS suppress LogErrors in Pixel unpacker
…s_in_alignment_validation

[13.2.X] Support HLT tracks in alignment validation
…Payloads_fix_BACKPORT_13_2

[13_2_X] fixed comparePayloads in LHInfo* PopCons
…erMeas_132X

add layer-TSOS compatibility check in `LayerMeasurements` [`13_2_X`]
…e_v2

[13_2_X] Add HARVEST step to SKIM WF for Run3
…tag_in_2023MC_gts

[13_2_X] Update 2023 MC GTs with the fixed L1T tag and re-snapshot the data GTs
…AreaFinder_13_2_X

[13.2.X] clear `badPixelDetsBarrel_` and `badPixelDetsEndcap_` in `PixelInactiveAreaFinder`
…rity-checks-part2

ECAL skip GPU unpacking of the rest of the block if a bad block is detected - 132x
…_post41632_132X

fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-cms-sw#41632 [`13_2_X`]
lauridsj and others added 5 commits August 1, 2023 11:50
…h_static_assert

Replace the SFINAE check with static_assert [13.2.x]
…132x

[Backport 13_2_X] Fix emission veto hook
Fix error code on fallback file open error with test, 13_2_X backport
@nhduongvn
Copy link
Contributor Author

This is a wrong pull request. Please discard.

@nhduongvn nhduongvn closed this Aug 9, 2023
@nhduongvn nhduongvn deleted the fix-chaining-in-rules branch August 9, 2023 20:34
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42529/36542

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2023

A new Pull Request was created by @nhduongvn for master.

It involves the following packages:

  • Alignment/CommonAlignment (alca)
  • CondCore/Utilities (db)
  • CondTools/RunInfo (db)
  • Configuration/AlCa (alca)
  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DPGAnalysis/Skims (pdmv)
  • DQM/BeamMonitor (dqm, db)
  • DQMOffline/Trigger (dqm)
  • EventFilter/CTPPSRawToDigi (reconstruction)
  • EventFilter/EcalRawToDigi (reconstruction)
  • FWCore/Catalog (core)
  • GeneratorInterface/Pythia8Interface (generators)
  • HLTrigger/Configuration (hlt)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • IOPool/Input (core)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/TkTrackingRegions (reconstruction)
  • RecoVertex/BeamSpotProducer (reconstruction, alca)
  • TrackingTools/MeasurementDet (reconstruction)

@SiewYan, @rappoccio, @bbilin, @pmandrik, @Saptaparna, @Martin-Grunewald, @alberto-sanchez, @menglu21, @tjavaid, @perrotta, @makortel, @cmsbuild, @missirol, @miquork, @fwyzard, @GurpreetSinghChahal, @mandrenguyen, @davidlange6, @smuzaffar, @consuegs, @Dr15Jones, @emanueleusai, @AdrianoDee, @syuvivida, @micsucmed, @fabiocos, @francescobrivio, @mkirsano, @nothingface0, @clacaputo, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @forthommel, @argiro, @Martin-Grunewald, @wddgit, @thomreis, @tlampen, @alberto-sanchez, @threus, @mmusich, @slomeo, @pakhotin, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @missirol, @HuguesBrun, @cericeci, @ferencek, @trocino, @grzanka, @rociovilar, @youyingli, @fabferro, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @bellan, @tocheng, @ebrondol, @mtosi, @fabiocos, @francescobrivio, @mkirsano, @adewit, @rchatter, @AnnikaStein, @Fedespring, @silviodonato, @dkotlins, @wang0jin, @gpetruc, @sameasy, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment