Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2023 HI scenarios #42493

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR adds the HI scenarios to be used in Tier0 for 2023 HI data-taking.
The new scenarios are based on the "2023" Eras introduced by @mandrenguyen in #41571.

Era Scenario
Run3_pp_on_PbPb_2023 ppEra_Run3_pp_on_PbPb_2023
Run3_pp_on_PbPb_approxSiStripClusters_2023 ppEra_Run3_pp_on_PbPb_approxSiStripClusters_2023

PR validation:

Code compiles and I also run:

scram b runtests_TestConfigDP

As far as I know we don't have streamer files on which the usual RunPromptReco.py command can be tested.

Backport:

Not a backport, but a 13_2_X backport will be provided soon


FYI @cms-sw/alca-l2 @cms-sw/ppd-l2 @mandrenguyen @icali @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42493/36497

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @cmsbuild, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42493/36498

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

Pull request #42493 was updated. @perrotta, @cmsbuild, @rappoccio, @fabiocos, @davidlange6 can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

urgent

  • the backport is supposed to be included in the next 13_2_X release and to be tested in Tier0 with a replay

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80bba2/34139/summary.html
COMMIT: ee44f85
CMSSW: CMSSW_13_3_X_2023-08-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42493/34139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150947
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150913
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit bce2eaf into cms-sw:master Aug 7, 2023
@francescobrivio francescobrivio deleted the alca-add_2023_HI_scenario branch November 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants