Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce variant of pp_on_PbPb era for 2023 #41571

Merged
merged 2 commits into from
May 11, 2023

Conversation

mandrenguyen
Copy link
Contributor

PR description:

In #41368 the Run3 era was split into Run3 and Run3_2023.
We extend this split to the heavy ion era: Run_pp_on_PbPb and Run_pp_on_PbPb_approxSiStripClusters by introducing 2023 variants.

PR validation:

Tested with 160. Other affected workflows are 160.02, 160.03, 160.1, 160.2, 160.3, 160.4

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport will be needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41571/35442

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @AnnikaStein, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test workflow 160, 160.02, 160.03, 160.1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5269f4/32438/summary.html
COMMIT: 07c5b24
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41571/32438/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
  • 140.027140.027_RunMET2022B/step2_RunMET2022B.log
  • 140.028140.028_RunEGamma2022B/step2_RunEGamma2022B.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 654 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3756929
  • DQMHistoTests: Total failures: 648
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3756259
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 227 log files, 177 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

please test
let's try again

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5269f4/32490/summary.html
COMMIT: 07c5b24
CMSSW: CMSSW_13_2_X_2023-05-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41571/32490/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

  • 12034.012034.0_TTbar_14TeV+2021Design/step2_TTbar_14TeV+2021Design.log
  • 12634.012634.0_TTbar_14TeV+2023PU/step2_TTbar_14TeV+2023PU.log
  • 12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2/step2_TTbar_14TeV+2023PU_PMXS1S2.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460836
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5269f4/32503/summary.html
COMMIT: 07c5b24
CMSSW: CMSSW_13_2_X_2023-05-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41571/32503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460836
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor Author

@cms-sw/pdmv-l2 Does this look ok for you?

@srimanob
Copy link
Contributor

+Upgrade

@kskovpen
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 50ce753 into cms-sw:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants