Revert BeamSpot fallback logic

[francescobrivio]

PR description:

After discussion at the Tracking POG meeting on 17^th July 2023, it was decided to revert the changes of the online BeamSpot fallback logic (used in HLT and Express) introduced in #41597.
This PR:

• Reverts commit 4b35c95 so that, when the ESProducer produces a fake BeamSpot, the framework will fallback to the DB, ie. to consuming the last result produced by the PCL
• Promotes the LogInfo(s) in OnlineBeamSpotESProducer.cc to LogWarning(s) in order to better debug why sometimes HLT picks up the fake BeamSpot (see discussion in HLT crash in run-368566 (BasicSingleVertexState error from PFTauPrimaryVertexProducer) #41914)
• Change in the bsChoice plot title to improve clarity

PR validation:

Code compiles + run successfully:

cmsRun DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py unitTest=True

Backport:

Not a backport, but backports to the data-taking releases will be provided soon.

FYI @gennai @dzuolo @lguzzi

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42284/36313

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)
• RecoVertex/BeamSpotProducer (reconstruction, alca)

@perrotta, @consuegs, @micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

test parameters:

• addpkg = DQM/Integration

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ace4e/33725/summary.html
COMMIT: b21e838
CMSSW: CMSSW_13_2_X_2023-07-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42284/33725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 51 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3195634
• DQMHistoTests: Total failures: 34
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3195578
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

testing 13_0 backport at p5

[francescobrivio]

@smuzaffar

smuzaffar modified the milestones: CMSSW_13_2_X, CMSSW_13_3_X Jul 18, 2023

does this mean it will be included in both 13_2_X and 13_3_X? Or it has been moved to 13_3_X only and I need to provide a 13_2_X backport?

Also, @smuzaffar @rappoccio @perrotta, this "modification of milestone" happens with no explicit ping (mail notification) to the PR author and IMHO that's not a good practice because we might loose some backports. Is there a way to improve this behavior?

I can bring this up later today at the ORP meeting or open an issue (in cms-bot?) in case it's a better place to discuss this.

[smuzaffar]

@francescobrivio , this will only be included in 13.3.X. For backport to 13.2.X , one needs to explicitly open a new PR

[emanueleusai]

+1

• p5 tests completed successfully and results are as expected

[mandrenguyen]

+1

[francescobrivio]

+db

• since I'm moving more toward db stuff I let my @cms-sw/alca-l2 colleagues sign for alca 😄

[saumyaphor4252]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1