Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary Dataset backport 130X #42084

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

jordan-martins
Copy link
Contributor

This is a backport of #42065

I am adding a new cff to handle the creation of a SD.
Adding the PDWG_ReserveDMu_SD_cff file
Adding the ReserveDMu SD for all the ParkingDoubleMuonLowMass PDs
Test file for the ReserveDMu Secondary Dataset
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jun 26, 2023
@jordan-martins
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2023

A new Pull Request was created by @jordan-martins (Jordan Martins) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #42065

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13528b/33381/summary.html
COMMIT: 9276657
CMSSW: CMSSW_13_0_X_2023-06-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42084/33381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 245 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3317136
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3317111
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor

+pdmv

@malbouis
Copy link
Contributor

@cms-sw/pdmv-l2 would you please sign this PR?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Verbatim backport of Making a new Secondary Dataset ReserveDMu #42065
  • These changes will not be effective until explicitly switched on at Tier0. Therefore, they are not dangerous for data taking even if merged in parallel with the master version

@cmsbuild cmsbuild merged commit ce34ad4 into cms-sw:CMSSW_13_0_X Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants