Custom_Muon_POG_NanoAOD

[rbhattacharya04]

Code to produce a custom NanoAOD for MuonPOG needs

• This code is developed to run on Run-3 MiniAODs
• Firstly the code was developed on CMSSW_12_6_0. Then I rebased it to CMSSW_13_2_0_pre2
• The extra variables needed for Muon POG are directly added to PhysicsTools/NanoAOD/python/muons_cff.py
• To add some variables an EDProducer was needed. And it is PhysicsTools/NanoAOD/plugins/MuonSpecialVariables.cc
• An EDProducer was also needed to produce tracks from Particle Flow candidates. It is in PhysicsTools/NanoAOD/plugins/pfTracksProducer.cc. and the corresponding python file is PhysicsTools/NanoAOD/python/pfTracks_cff.py
• To save only the muons in the final NanoAOD, I modified PhysicsTools/NanoAOD/python/NanoAODEDMEventContent_cff.py

I have checked the code compiles and run. I have also checked the output NanoAOD is in the expected format.

I have also checked that the code passes the basic tests mentioned in https://cms-sw.github.io/PRWorkflow.html

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36020

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/NanoAODEDMEventContent_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): Update Muon MVA ID model and working points in MiniAOD and NanoAOD #41903
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Nm dqm egamma v update for13 1 x #41987

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36020/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36020/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36020/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36020/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36321

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @rbhattacharya04 for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42039/36364

• This PR adds an extra 124KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add HARVEST step to SKIM WF for Run3 #42277, Update 2023 FastSim beamspot #42327
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Update 2023 FastSim beamspot #42327, Add run3 tracking low pu era #33532, Clean Up for Pixel Tracks - Follow-up to #41632 #42304

[cmsbuild]

Pull request #42039 was updated. @vlimant, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @simonepigazzini, @sunilUIET can you please check and sign again.

[simonepigazzini]

Although this approach works, it is not the way we want custom nano to be implemented.

You should define a dedicated sequence that produces only the flat tables you are interested in or define a customize function that changes the content of the standard nano. You should leave the output module untouched, it will dump every flat table present in the event stream.

In practical terms, if you still want to run most of the standard nano sequence, you should just add a customize function that adds the relevant variables to the muon flat tables. If instead most of the standard content is dropped, you should define a new sequence that only include the producers of the required tables.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b83ade/34967/summary.html
COMMIT: 3cca89c
CMSSW: CMSSW_13_3_X_2023-09-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42039/34967/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358320
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358295
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[simonepigazzini]

+1

[srimanob]

+Upgrade

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b83ade/35493/summary.html
COMMIT: 3cca89c
CMSSW: CMSSW_13_3_X_2023-10-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42039/35493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 29 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362691
• DQMHistoTests: Total failures: 1073
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361596
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1