Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011

AdrianoDee · 2023-03-09T16:13:37Z

PR description:

Allowing all Phase2 geometries for Patatrack wfs. The new wfs will inherit then the numbering 23634.* and 23834.* (no PU, PU). Adding also the various FullRecoGPU wfs for Phase2 (e.g. .582, .592, ...).

PR validation:

None. Technical PR. Testing the new wfs.

AdrianoDee · 2023-03-09T16:14:24Z

test parameters:

enable = gpu
workflows_gpu = 10824.592,10824.593,10824.596,10824.597,11634.593,11634.596
relvals_opt_gpu = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

cmsbuild · 2023-03-09T16:18:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41011/34533

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643

cmsbuild · 2023-03-09T16:19:22Z

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2023-03-09T16:29:47Z

test parameters:

enable = gpu
workflows_gpu = 23634.592,23634.593,23634.596,23634.597,23834.593,23834.596,23834.597
relvals_opt_gpu = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

AdrianoDee · 2023-03-09T16:30:05Z

please test

cmsbuild · 2023-03-09T18:54:47Z

-1

Failed Tests: RelVals-GPU
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68f47d/31167/summary.html
COMMIT: 1a18ad2
CMSSW: CMSSW_13_1_X_2023-03-08-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41011/31167/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

ValueError: Undefined workflows: 23834.593, 23834.596, 23634.596, 23634.592, 23634.593, 23634.597, 23834.597

Comparison Summary

Summary:

You potentially removed 8 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3530381
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3530355
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-03-10T11:54:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41011/34546

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): HLT menu development for 13_0_X (4/N) [13_1_X] #41016, Add run3 tracking low pu era #33532, Displaced regional tracking iteration #40643

cmsbuild · 2023-03-10T11:55:13Z

Pull request #41011 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

AdrianoDee · 2023-03-10T12:07:38Z

please test

srimanob · 2023-08-29T15:22:53Z

+Upgrade

AdrianoDee · 2023-09-05T08:40:21Z

+pdmv

cmsbuild · 2023-09-05T08:40:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

AdrianoDee · 2023-09-05T11:23:56Z

please test

cmsbuild · 2023-09-05T21:45:53Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68f47d/34610/summary.html
COMMIT: 870e866
CMSSW: CMSSW_13_3_X_2023-09-05-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41011/34610/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

You potentially removed 18 lines from the logs
Reco comparison results: 25 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153414
DQMHistoTests: Total failures: 2345
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3151047
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 40118
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 40097
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

AdrianoDee · 2023-09-06T06:40:58Z

please test

cmsbuild · 2023-09-06T09:15:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68f47d/34633/summary.html
COMMIT: 870e866
CMSSW: CMSSW_13_3_X_2023-09-05-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41011/34633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 11 lines to the logs
Reco comparison results: 34 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3153414
DQMHistoTests: Total failures: 1499
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3151893
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 3
DQMHistoTests: Total histograms compared: 40118
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 40098
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
Checked 8 log files, 10 edm output root files, 3 DQM output files
TriggerResults: no differences found

antoniovilela · 2023-09-07T11:39:28Z

+1

cmsbuild added this to the CMSSW_13_1_X milestone Mar 9, 2023

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels Mar 9, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 9, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 9, 2023

cmsbuild mentioned this pull request Mar 9, 2023

HLT menu development for 13_0_X (4/N) [13_1_X] #41016

Merged

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels Mar 9, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 10, 2023

AdrianoDee changed the title ~~Adding D95 Patatack wfs~~ Adding D95 Patatack wfs and the FullRecoGPU wfs for Phase2 Mar 10, 2023

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2023

cmsbuild mentioned this pull request Aug 29, 2023

[HGCAL trigger] Module splitting and updated seeding normalization #42246

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 29, 2023

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Sep 5, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 5, 2023

cmsbuild added tests-rejected and removed tests-started labels Sep 5, 2023

cmsbuild added tests-started and removed tests-rejected labels Sep 6, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 7, 2023

cmsbuild merged commit 0a9cdd2 into cms-sw:master Sep 7, 2023
13 checks passed

AdrianoDee deleted the d95_patatrack branch September 20, 2023 14:34

srimanob mentioned this pull request Jan 17, 2024

Update Patatrack wf in relval_2026 #43736

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011

Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011

AdrianoDee commented Mar 9, 2023 •

edited

Loading

AdrianoDee commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

AdrianoDee commented Mar 9, 2023

AdrianoDee commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 10, 2023

cmsbuild commented Mar 10, 2023

AdrianoDee commented Mar 10, 2023

srimanob commented Aug 29, 2023

AdrianoDee commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

AdrianoDee commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

AdrianoDee commented Sep 6, 2023

cmsbuild commented Sep 6, 2023

antoniovilela commented Sep 7, 2023

Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011

Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2 #41011

Conversation

AdrianoDee commented Mar 9, 2023 • edited Loading

PR description:

PR validation:

AdrianoDee commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

AdrianoDee commented Mar 9, 2023

AdrianoDee commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

RelVals-GPU

Comparison Summary

cmsbuild commented Mar 10, 2023

cmsbuild commented Mar 10, 2023

AdrianoDee commented Mar 10, 2023

srimanob commented Aug 29, 2023

AdrianoDee commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

AdrianoDee commented Sep 5, 2023

cmsbuild commented Sep 5, 2023

Unit Tests

Comparison Summary

GPU Comparison Summary

AdrianoDee commented Sep 6, 2023

cmsbuild commented Sep 6, 2023

Comparison Summary

GPU Comparison Summary

antoniovilela commented Sep 7, 2023

AdrianoDee commented Mar 9, 2023 •

edited

Loading