Remove obsolete Scouting Data Format unit tests

[wddgit]

PR description:

Remove obsolete Scouting Data Format unit tests

These tests were replaced by newer tests and there is discussion related to that in the PR comments of the PRs adding the new unit tests. See #41913 and #41834.

PR validation:

This only removes obsolete unit tests. There is nothing to test. The newer unit tests that replace them still pass after removal.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41964/35929

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

• DataFormats/Scouting (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[wddgit]

There is one thing related to these old tests that bothers me slightly. I am leaning towards just ignoring this, but if someone thinks it is worth investigating I will or maybe someone else should...

In the IBs in the ROOT6_X area, the tests removed by this PR are failing. It is only in ROOT6_X build, in all the others it passes. Does anyone understand this? Is it worth worrying about? The log file output is gigantic so it is hard to look at and I don't understand it...

===== Test "testDataFormatsScoutingRun2" ====
...
/data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_13_2_ROOT6_X_2023-06-12-2300/src/DataFormats/Scouting/test/testDataFormatsScoutingRun2.sh: line 26: 2815602 Killed                  "${SCRAM_TEST_PATH}"/scoutingCollectionsDumper.py -v 1 -n 1 --skip 81 -i testDataFormatsScoutingRun2_step1.root -k Scouting > testDataFormatsScoutingRun2_step2.log 2> testDataFormatsScoutingRun2_step2_stderr.log

Failure running scoutingCollectionsDumper.py: status 137
=== Log File ==========
malloc_consolidate(): unaligned fastbin chunk detected
 *** Break *** abort
malloc(): unsorted double linked list corrupted
 *** Break *** abort
...

[wddgit]

please test

[makortel]

In the IBs in the ROOT6_X area, the tests removed by this PR are failing. It is only in ROOT6_X build, in all the others it passes. Does anyone understand this? Is it worth worrying about?

@pcanal is investigating the crash (more details in #41222).

[makortel]

Let's keep @missirol in the loop

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7ab83/33162/summary.html
COMMIT: 3d1d0d7
CMSSW: CMSSW_13_2_X_2023-06-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41964/33162/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196030
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

hold

Until the ROOT problem with the earlier test is understood (#41222 (comment))

[cmsbuild]

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[makortel]

@cmsbuild, please test

[makortel]

unhold

[makortel]

Until the ROOT problem with the earlier test is understood (#41222 (comment))

The ROOT problem was worked around (see the issue for more details), while waiting for the proper fix.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7ab83/34618/summary.html
COMMIT: 3d1d0d7
CMSSW: CMSSW_13_3_X_2023-09-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41964/34618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 21 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153414
• DQMHistoTests: Total failures: 2345
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3151047
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #39803

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1