Adding filter flag to SiStripApproximateClusters

[Ksavva1021]

PR description:

This PR extends the SiStripApproximateCluster data format to include a boolean flag of the outcome of the StripSubClusterShapeTrajectoryFilter sequence. This boolean flag serves the purpose of overriding the three checks in StripSubClusterShapeTrajectoryFilter module which introduced inefficiencies in tracking performance. These inefficiencies arise due to the uniform shape of the approximated clusters. The problem-causing filters were the "saturated", "trimming" and "peak finder" filters with the latter two requiring information on the trajectory state on the surface at the measurement layer which is not available during clustering.

This PR utilises information on the beamspot, tracker geometry, and strip module to approximate the global position of the cluster and the track direction. The latter is done by drawing a vector from the beamspot to the cluster barycenter. A boolean for the 3 filters is then set up using this information following the logic in the StripSubClusterShapeTrajectoryFilter module.

PR validation:

This PR was tested by running workflows 11884.0 and 11941.0 (step3). The DQM outputs have been checked and compared to the original clusters to compare any performance gains from this new implementation.

@mmusich @mtosi

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41815/35702

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @Ksavva1021 for master.

It involves the following packages:

• DataFormats/SiStripCluster (reconstruction)
• RecoLocalTracker/SiStripClusterizer (reconstruction)
• RecoTracker/PixelLowPtUtilities (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @swertz, @missirol, @GiacomoSguazzoni, @yduhm, @robervalwalsh, @JanFSchulte, @rovere, @VinInn, @alesaggio, @gpetruc, @felicepantaleo, @mtosi, @gbenelli, @mmusich, @threus, @dgulhan, @jlidrych this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41815/35706

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #41815 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41815/35708

• This PR adds an extra 44KB to repository

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e01bcc/33347/summary.html
COMMIT: a185ded
CMSSW: CMSSW_13_2_X_2023-06-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41815/33347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3307432
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3307385
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 162 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
Resign. Warning messages in 140.58 from missing beamspot are gone with latest commit, which switches to the HLT online beamspot.

[missirol]

+hlt

(DQM bin-by-bin comparisons seem unavailable, see #42050.)

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[perrotta]

@Ksavva1021 this PR is likely making crash workflows 159.02, 159.03, 160.02, 160.03 in the IBs, with error message:

----- Begin Fatal Exception 26-Jun-2023 02:49:48 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Calling method for module ScalersRawToDigi/'hltScalersRawToDigi'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: FEDRawDataCollection
Looking for module label: rawDataRepacker
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Could you please have a look?

[mmusich]

@perrotta, see #42087

[perrotta]

@perrotta, see #42087

Thank you @mmusich !