Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1NANO in Prompt/Tier0 configuration [13_1_X] #41889

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jun 7, 2023

PR description:

Title says all
Backport of #41868 in 13_1_X: since a similar backport already exists for 13_0_X (see #41884) this will avoid holes in the release cycles

PR validation:

Same commit already merged in master, and going to be merged in 13_0_X as well

@vlimant

@perrotta
Copy link
Contributor Author

perrotta commented Jun 7, 2023

backport of #41868

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Jun 7, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31b16c/33025/summary.html
COMMIT: cd92dac
CMSSW: CMSSW_13_1_X_2023-06-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41889/33025/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221560
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

perrotta commented Jun 7, 2023

@vlimant (or @cms-sw/xpog-l2 at large) please confirm that there is nothing that prevents this to be merged also in 13_1_X, as it is now both in 13_0_X and 13_2_X.

@perrotta
Copy link
Contributor Author

perrotta commented Jun 8, 2023

+1

  • I can't see any reason for not having this also in the intermediate 13_1_X releases: let merge it

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c2dd0c3 into cms-sw:CMSSW_13_1_X Jun 8, 2023
@perrotta perrotta deleted the L1NANOinPromptReco_13_1_X branch June 8, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants