Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add L1nano NANO in Prompt/Tier0 configuration #41868

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Jun 5, 2023

PR description:

after discussion with @drkovalskyi , we propose to add the L1NANO customisation function in DataProcessing where T0 picks up its configuration.

a 13.0.X backport is imminent for this, after agreed with Tier0 operation https://its.cern.ch/jira/browse/CMSTZ-1046

PR validation:

python3 $CMSSW_BASE/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario ppEra_Run3 --reco --aod --miniaod --nanoaod --dqmio --alcareco TkAlMinBias+SiStripCalMinBias --lfn=/eos/cms/tier0/store/data/Run2023C/HLTPhysics/RAW/v1/000/368/382/00000/86a26e18-1c93-48f2-a4bd-384d1cca7dbf.root --global-tag 130X_dataRun3_Prompt_v3

was run successfully, and the L1 branches were located in the output dataset

@cmsbuild cmsbuild added this to the CMSSW_13_2_X milestone Jun 5, 2023
@vlimant vlimant changed the title add L1nano customise if NANO is requested add L1nano NANO in Prompt/Tier0 configuration Jun 5, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41868/35776

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

A new Pull Request was created by @vlimant (vlimant) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f82b2/32982/summary.html
COMMIT: 6382d82
CMSSW: CMSSW_13_2_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41868/32982/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219884
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jun 5, 2023

+1

  • Based on the validation reported in the PR description

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants