Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.X] use onlineMetaDataDigis when available for retrieval of average PU in AlCaHOCalibProducer #41519

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 4, 2023

backport of #41486

PR description:

This PR addresses one of the worst offenders in terms of LogError emissions recently collected at #41456.
As the title says, use onlineMetaDataDigis when available for retrieval of average online PU in AlCaHOCalibProducer (lumiscalers were decommisioned at the beginning of Run-3).
See #41456 (comment) and following for more details.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #41486, needed for data-taking (reduce amount of LogError-s in Prompt Reco)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2023

type hcal

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d371a/32386/summary.html
COMMIT: 9652c05
CMSSW: CMSSW_13_0_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41519/32386/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554764
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554738
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 5, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 5, 2023

+1

@cmsbuild cmsbuild merged commit 4db62ff into cms-sw:CMSSW_13_0_X May 5, 2023
@mmusich mmusich deleted the use_online_metadata_in_AlCaHOCalibProducer_13_0_X branch May 5, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants