use onlineMetaDataDigis when available for retrieval of average PU in AlCaHOCalibProducer

[mmusich]

PR description:

This PR addresses one of the worst offenders in terms of LogError emissions recently collected at #41456.
As the title says, use onlineMetaDataDigis when available for retrieval of average online PU in AlCaHOCalibProducer (lumiscalers were decommisioned at the beginning of Run-3).
See #41456 (comment) and following for more details.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a backport to 13.0.X would be desireable

[mmusich]

@bsunanda I am wondering if the original intentions here are correct. the variable suggests it's about the instantaneous lumi, but what was actually used was the pile-up.
At any rate I have preserved the behaviour.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41486/35351

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@bsunanda, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93b677/32307/summary.html
COMMIT: 5bd611f
CMSSW: CMSSW_13_1_X_2023-05-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41486/32307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460846
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

Thanks a lot Marco for this!
I'd be ready to sign it, but should we hear the opinion of HCAL experts @bsunanda @abdoulline?

[francescobrivio]

type hcal

[tvami]

+alca

• the PR is technical in the sense it accesses the same info as earlier (but through the rcd instead of the event)
• one question to HCAL experts here use onlineMetaDataDigis when available for retrieval of average PU in AlCaHOCalibProducer #41486 (comment) should be followed-up

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

what's preventing this to be merged?

[francescobrivio]

And now we also need a 13_1_X backport :(

[abdoulline]

@bsunanda could you, please take a look (together with Gobinda?)

[perrotta]

+1

• Please @bsunanda have a look at use onlineMetaDataDigis when available for retrieval of average PU in AlCaHOCalibProducer #41486 (comment)