Run3-hcx335 Add protection to eta values for phase2 scenario in HCAL geometry

[bsunanda]

PR description:

Add protection to eta values for phase2 scenario in HCAL geometry. Protect against use of the wrong PU file in phase2 scenario. This is a bug fix and a protection for wrong usage

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This needs to be back ported to 12_5_X and 12_4_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32835

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32835/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32835/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32836

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• CondFormats/GeometryObjects (db, alca)
• Geometry/HcalCommonData (geometry)

@malbouis, @civanch, @Dr15Jones, @makortel, @saumyaphor4252, @ianna, @mdhildreth, @cmsbuild, @bsunanda, @yuanchao, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32841

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32841/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32841/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@tvami @ChrisMisan @srimanob I just squashed the commits. No other changes made. Can you sign this urgently?

[bsunanda]

+geometry

[tvami]

+1

• just squashed commits since last signature

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39920/32862

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #39920 was updated. can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df6969/28669/summary.html
COMMIT: 6fc8f83
CMSSW: CMSSW_12_6_X_2022-10-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39920/28669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416356
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3416325
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rappoccio]

+1

• Straightforward protection, comparisons look good.