Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on protection to eta values for phase2 scenario in HCAL #39950

Closed
srimanob opened this issue Nov 1, 2022 · 4 comments
Closed

Follow up on protection to eta values for phase2 scenario in HCAL #39950

srimanob opened this issue Nov 1, 2022 · 4 comments

Comments

@srimanob
Copy link
Contributor

srimanob commented Nov 1, 2022

This issue is to follow the discussion of the PR #39920 and part of it in #39928

The PR #39920 states to be a protection against using the wrong PU file in phase2 scenario. My assumption is that if we do correct MinBias file, we will not have issue. And protection will not needed.

However, what mentioned here,
#39928 (comment)
"this happens in cases where a cell which is valid in run2 or 3 appears ina geometry setup of run4. This can happen either for signal or for pileup files (the second case is more likely).",
It seems to be a bug and need a fix, not a protection.

Could we have a clear statement of what is wrong, exactly? Or any pointer to presentation of discussion. Now, I am not sure what "wrong PU file" means.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2022

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Nov 1, 2022

I would suggest to keep the discussion in the issues that are already open. #39480 has been more active recently than #39445.

@srimanob
Copy link
Contributor Author

srimanob commented Nov 1, 2022

Hi @makortel

I have to admit, I confuse. Is this PR #39920 needed at the end? This issue is to follow what is the goal of the fix, i.e. wrong HCAL ID. But if the issue is the same as #39480, then I assume #39920 is not needed.

@srimanob srimanob closed this as completed Nov 1, 2022
@makortel
Copy link
Contributor

makortel commented Nov 1, 2022

The PR #39920 looks like a followup to a comment #39480 (comment). Since the impact of #39920 was to "just" make the error condition more visible via exception in contrast to semi-random crashes, I'm pretty sure the underlying cause is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants