Extend alternative module type loading to EventSetup #39391

makortel · 2022-09-14T14:01:44Z

PR description:

This PR extends the alternative module type loading, that was introduced in #37731 for EDModules, to EventSetup sources and modules. I'm not sure if this feature would be really useful for ESSources, because for GPUs the use case is really about transferring data from existing ESProducts on existing Records, but it was tiny bit simpler to allow the mechanism also for ESSources. For Loopers the mechanism is explicitly disabled.

Resolves cms-sw/framework-team#435

PR validation:

Framework unit tests run.

…dRethrow()

In order to use from ComponentFactory<T> for EventSetup

cmsbuild · 2022-09-14T14:12:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39391/32093

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/EventSetupsController.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
- File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Modified data product delete early system #38983, Implement support for concurrent runs in the Framework #38801
- File FWCore/Framework/src/EventSetupsController.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801

cmsbuild · 2022-09-14T14:13:19Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

makortel · 2022-09-14T14:22:03Z

@cmsbuild, please test

FWCore/Framework/interface/EventSetupProvider.h

Dr15Jones · 2022-09-14T14:36:08Z

FWCore/Framework/src/Factory.cc

-        return MakerPluginFactory::get()->create(modtype);
-      };
-      std::unique_ptr<Maker> wm = make(resolver, modtype, p);
+      std::unique_ptr<Maker> wm = detail::resolveMaker<MakerPluginFactory>(modtype, resolver);


nice sharing

Dr15Jones · 2022-09-14T14:40:11Z

Seems OK

cmsbuild · 2022-09-14T21:40:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb5032/27540/summary.html
COMMIT: 0e854ed
CMSSW: CMSSW_12_6_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39391/27540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618326
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618302
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

…dules

cmsbuild · 2022-09-15T00:15:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39391/32097

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/EventSetupsController.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
- File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Modified data product delete early system #38983, Implement support for concurrent runs in the Framework #38801
- File FWCore/Framework/src/EventSetupsController.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801

cmsbuild · 2022-09-15T00:15:23Z

Pull request #39391 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

makortel · 2022-09-15T00:52:32Z

@cmsbuild, please test

cmsbuild · 2022-09-15T07:12:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb5032/27546/summary.html
COMMIT: 8e92ec6
CMSSW: CMSSW_12_6_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39391/27546/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618326
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618296
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

makortel · 2022-09-15T13:36:29Z

+1

cmsbuild · 2022-09-15T13:36:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-09-15T17:29:44Z

+1

makortel added 3 commits September 14, 2022 15:20

Remove unnecessary MakeModuleParams argument from annotateExceptionAn…

ed712d9

…dRethrow()

Abstract the use of ModuleTypeResolverBase into its own function

2bad3e9

In order to use from ComponentFactory<T> for EventSetup

Code format for ComponentFactory.h

9ac8d84

makortel mentioned this pull request Sep 14, 2022

Extend "alternative module loading" infrastructure to ESModules cms-sw/framework-team#435

Closed

cmsbuild added this to the CMSSW_12_6_X milestone Sep 14, 2022

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Sep 14, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 14, 2022

Dr15Jones reviewed Sep 14, 2022

View reviewed changes

FWCore/Framework/interface/EventSetupProvider.h Outdated Show resolved Hide resolved

Dr15Jones reviewed Sep 14, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Sep 14, 2022

Allow ModuleTypeResolverBase to be used for EventSetup sources and mo…

8e92ec6

…dules

makortel force-pushed the moduleTypeResolverEventSetup branch from 0e854ed to 8e92ec6 Compare September 15, 2022 00:07

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Sep 15, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 15, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 15, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 15, 2022

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Sep 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Sep 15, 2022

cmsbuild merged commit bf366b7 into cms-sw:master Sep 15, 2022

makortel deleted the moduleTypeResolverEventSetup branch September 15, 2022 21:38

makortel mentioned this pull request Sep 20, 2022

Crashes in workflow 39434.911 #39445

Closed

makortel mentioned this pull request Sep 30, 2022

Move EventSetup module PSet validation to be called from ComponentMaker #39556

Merged

makortel mentioned this pull request Dec 21, 2022

Improve module type resolver system so that it would be usable for Alpaka modules #40383

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend alternative module type loading to EventSetup #39391

Extend alternative module type loading to EventSetup #39391

makortel commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

makortel commented Sep 14, 2022

Dr15Jones Sep 14, 2022

Dr15Jones commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

cmsbuild commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

makortel commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

makortel commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

perrotta commented Sep 15, 2022

Extend alternative module type loading to EventSetup #39391

Extend alternative module type loading to EventSetup #39391

Conversation

makortel commented Sep 14, 2022

PR description:

PR validation:

cmsbuild commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

makortel commented Sep 14, 2022

Dr15Jones Sep 14, 2022

Choose a reason for hiding this comment

Dr15Jones commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

Comparison Summary

cmsbuild commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

makortel commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

Comparison Summary

makortel commented Sep 15, 2022

cmsbuild commented Sep 15, 2022

perrotta commented Sep 15, 2022