New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend "alternative module loading" infrastructure to ESModules #435

Closed

makortel opened this issue Sep 10, 2022 · 2 comments · Fixed by cms-sw/cmssw#39391

Assignees

Labels

Task

Milestone

Support Alpaka's ...

Collaborator

makortel commented Sep 10, 2022

I.e. this PR cms-sw/cmssw#37731 (#392). I think the corresponding place in EventSetup system is around
https://github.com/cms-sw/cmssw/blob/e7a6a4e6c3078e137a31bd44f89300f9d1f4861f/FWCore/Framework/src/EventSetupProviderMaker.cc#L95-L104
and
https://github.com/cms-sw/cmssw/blob/e7a6a4e6c3078e137a31bd44f89300f9d1f4861f/FWCore/Framework/interface/ComponentFactory.h#L58-L61

makortel added the Activity label

makortel added this to the Support Alpaka's integration into CMSSW milestone

makortel added Task and removed Activity labels

Collaborator Author

makortel commented Sep 10, 2022

fillEventSetupProvider() is called from
https://github.com/cms-sw/cmssw/blob/e7a6a4e6c3078e137a31bd44f89300f9d1f4861f/FWCore/Framework/src/EventSetupsController.cc#L57

EventSetupsController::makeProvider() is called from (among other places)
https://github.com/cms-sw/cmssw/blob/e7a6a4e6c3078e137a31bd44f89300f9d1f4861f/FWCore/Framework/src/EventProcessor.cc#L473-L474
and the EventSetupsController itself is constructed in
https://github.com/cms-sw/cmssw/blob/e7a6a4e6c3078e137a31bd44f89300f9d1f4861f/FWCore/Framework/src/EventProcessor.cc#L246

makortel self-assigned this

makortel mentioned this issue

Extend alternative module type loading to EventSetup cms-sw/cmssw#39391

Merged

Collaborator Author

makortel commented Sep 14, 2022

Done in cms-sw/cmssw#39391

makortel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment