Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tracker Alignment di-muon monitoring to other resonances #39295

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 2, 2022

PR description:

This PR extends on the concept introduced at #39148 (and then followed up at #39173 and #39217) in order to monitor the vertexing and mass biases for other di-muon resonances (J/ψ→µµ and Υ(1S) →µµ) used in the tracker alignment procedure.

PR validation:

Relies on the existing (and augmented) unit tests.
The output of it has been uploaded to a test GUI for convenience of inspection and it's available by connecting to:

 ssh -NL 8060:localhost:8060 <USER>@lxplus724.cern.ch

and visiting:

Morevor the single bin fits for the resonance masses are available here

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but will be backported to 12.5.x and 12.4.x for data-taking monitoring purposes.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 2, 2022

test parameters:

  • workflow = 1002.4
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

@mmusich mmusich changed the title Add Tracker Alignment di-muon monitoring to athor resonances Add Tracker Alignment di-muon monitoring to other resonances Sep 2, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39295/31975

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Alignment (dqm)
  • DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea2f1c/27304/summary.html
COMMIT: 02ccf33
CMSSW: CMSSW_12_6_X_2022-09-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39295/27304/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39295/31987

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

Pull request #39295 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 5, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea2f1c/27337/summary.html
COMMIT: 71a6ed7
CMSSW: CMSSW_12_6_X_2022-09-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39295/27337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ea2f1c/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3720003
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3719971
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 273.211 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 66.880 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 66.710 KiB AlCaReco/TkAlJpsiMuMu
  • DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0,... ): -0.004 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1002.4 ): 69.892 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1002.4 ): 69.675 KiB AlCaReco/TkAlJpsiMuMu
  • Checked 215 log files, 49 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants