DiMuonMassBiasClient: add protection for empty input histogram in the fitting function

[mmusich]

resolves #39180

PR description:

Title says it all, forward-port of commit e03333c from PR #39166, needed to avoid getting stuck with the Voigtian fit on empty input histograms.
Also it removes from the path being run DiMuonMassBiasClient as it doesn't support (yet) concurrent lumis, see #39180 (comment)

PR validation:

The unit test in the backport PR #39166 with this commit now runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Forward-port from #39166

[mmusich]

type bug-fix, trk

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39173/31762

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQMOffline/Alignment (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27055/summary.html
COMMIT: e94b2f1
CMSSW: CMSSW_12_5_X_2022-08-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39173/27055/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Michael-Krohn HCAL: Modifications to the LUT and trigger key generation script #39154
• @mmusich introduce DiMuonMassBiasClient and use in ALCARECOTkAlDiMuonAndVertexDQM #39148
• @srimanob Update input of phase2_digi_reco_pixelntuple unit test #39123
• @ChrisMisan Fix OOT plot in PPS Diamond DQM #39132
• @davidwalter2 Updates on DQMOffline/ZCounting #39119
• @missirol allow TriggerResultsFilter to throw for invalid HLTPathStatus patterns #39044

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27055/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27055/git-merge-result

Comparison Summary

Summary:

• You potentially added 4054 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3693053
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.008 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mmusich]

enable threading

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39173/31775

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #39173 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27064/summary.html
COMMIT: dcc4868
CMSSW: CMSSW_12_5_X_2022-08-24-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39173/27064/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @missirol allow TriggerResultsFilter to throw for invalid HLTPathStatus patterns #39044

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27064/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdacf1/27064/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3693053
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[qliphy]

urgent

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• @mmusich as you removed ALCARECOTkAlDiMuonMassBiasClient from the paths being run, how did you check that the fix is actually doing what intended? Is there a unit function somewhere that still test it, as you are suggesting in the PR description?

[mmusich]

@perrotta

as you removed ALCARECOTkAlDiMuonMassBiasClient from the paths being run, how did you check that the fix is actually doing what intended? Is there a unit function somewhere that still test it, as you are suggesting in the PR description

Yes, there is:

cmssw/DQMOffline/Alignment/test/testDiMuonVertexMonitor.sh

Line 11 in 562ab39

cmsRun ${LOCAL_TEST_DIR}/DiMuonVertex_HARVESTING.py || die "Failure using DiMuonVertex_HARVESTING.py" $?

which calls:

cmssw/DQMOffline/Alignment/test/DiMuonVertex_HARVESTING.py

Lines 118 to 123 in 562ab39

	process.diMuonBiasClient = cms.Sequence(process.DiMuonMassBiasClient)
	# trick to run the harvester module
	process.alcaHarvesting.insert(1,process.diMuonBiasClient)
	# Schedule definition
	process.schedule = cms.Schedule(process.alcaHarvesting,process.dqmsave_step)

Without the fix in commit e94b2f1 the unit test in the 12.4.x backport was failing, see log, but after the fix (and before removing ALCARECOTkAlDiMuonMassBiasClient from the path being run) the tests did succed (see #39166 (comment)).
This is how I noticed that a protection was needed, because the input files of the unit test are different in 12.4.x than in master and generated the error state not previously seen in the master IBs.
I hope this explains

[perrotta]

Perfect, thank you @mmusich !