-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove run2_HLTconditions_2018 modifier from Run3 setting #39084
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39084/31593
|
A new Pull Request was created by @davidwalter2 for master. It involves the following packages:
@perrotta, @rappoccio, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
Afaics, the net change from this PR will be in nanoAOD wfs using
@cms-sw/xpog-l2 should probably review this. |
assign xpog |
New categories assigned: xpog @mariadalfonso,@gouskos,@swertz,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks |
The preferring weights are different based on the year and loaded from here |
|
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals-INPUT
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39084/31662
|
Pull request #39084 was updated. @perrotta, @rappoccio, @gouskos, @swertz, @vlimant, @fabiocos, @cmsbuild, @qliphy, @mariadalfonso, @davidlange6 can you please check and sign again. |
@mariadalfonso |
Now this PR is marked as merged because in the commit chain of PR39119 the same commit was done but reverted again. |
Well. |
PR description:
As discussed in PR 39082, we remove the run2_HLTconditions_2018 from Run3 era setting to avoid using the 2018 specific settings.
PR validation:
validated via cmsDriver.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
We intent to do a backport to 12_4