Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefiring weight parametrizations for muon L1 prefiring #2

Merged
merged 1 commit into from
May 26, 2021

Conversation

JanFSchulte
Copy link
Contributor

Adds the ROOT file containing the TF1 objects for the muon L1 prefire parametrizations introduced in cms-sw/cmssw#33758.

@cmsbuild
Copy link

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for branch master.

@perrotta, @smuzaffar, @iarspider, @mrodozov, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @schoef, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
cms-bot commands are listed here

@perrotta
Copy link

+1

  • This adds the parameterizations needed to compute the L1 muon prefiring rate, which will be used by #33758
  • The added file is not required by any other CMSSW module before merging #33758, and therefore merging this external in advance with respect to that PR won't affect any current workflow, while it will help testing it in more detail

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5519fb/15268/summary.html
COMMIT: 61557d5
CMSSW: CMSSW_12_0_X_2021-05-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/PhysicsTools-PatUtils/2/15268/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650451
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link

can this be merged ? the test in cmssw#33758 pass successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants