Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracking efficiencies w.r.t. offline to HLT monitoring client #38959

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Add tracking efficiencies w.r.t. offline to HLT monitoring client #38959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQMOffline/Configuration/python/DQMOffline_SecondStep_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
DQMMessageLoggerClientSeq )


HLTMonitoringClient = cms.Sequence(trackingMonitorClientHLT * trackingForDisplacedJetMonitorClientHLT)
HLTMonitoringClient = cms.Sequence(trackingMonitorClientHLT * trackEfficiencyMonitoringClientHLT * trackingForDisplacedJetMonitorClientHLT)
HLTMonitoringClientPA= cms.Sequence(trackingMonitorClientHLT * PAtrackingMonitorClientHLT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to update HLTMonitoringClientPA in the same way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be useful but, since that's the client used in the Heavy-Ions scenario, I would let @FHead comment

Copy link
Contributor

@missirol missirol Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FHead , there is a question on a HLT-DQM sequence for HIon. Do you know who could provide feedback to @kjpena ?

(cross-posted..)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me tag relevant HI tracking and HLT people @abaty @CesarBernardes @denerslemos to see if they have inputs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abaty @CesarBernardes @denerslemos

Do you have any inputs?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Since pA is similar to pp, I think would be good to include trackEfficiencyMonitoringClientHLT in HLTMonitoringClientPA. Thanks

Copy link
Contributor Author

@kjpena kjpena Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input @denerslemos I will go ahead and update the HLTMonitoringClientPA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denerslemos, please note that HI sequences will not be updated in this PR, as discussed below. If needed, we can follow up with a separate PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjpena, ok, thank you so much for the efforts. I think it's a great idea to follow up using a separate PR.


DQMOffline_SecondStep = cms.Sequence(
Expand Down