Run3-alca223 Fixes the issue reported in #38656

[bsunanda]

PR description:

Try to address the issue (compilation warnings) reported in #38656
Fixes #38656

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38662/30952

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38662/30952/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38662/30952/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tvami]

@bsunanda please do code checks and squash it into the first commit

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38662/30953

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[tvami]

@cmsbuild , please test for CMSSW_12_5_LTO_X

[tvami]

@bsunanda if this works, you'll also need to rename the PR, just saying it fixes the issue doesnt say much on the release notes

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee2beb/26094/summary.html
COMMIT: 72c6baa
CMSSW: CMSSW_12_5_X_2022-07-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38662/26094/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3655935
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3655899
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee2beb/26095/summary.html
COMMIT: 72c6baa
CMSSW: CMSSW_12_5_LTO_X_2022-07-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38662/26095/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoLocalTracker #38552
• @bsunanda Run3-gex136B Handle compilation warnings in CalibMuon/CSCCalibration #38647
• @marco-link Fix issue with BTV HLT OfflineDQM #38635
• @finnlabe B2G SD mass jet trigger DQM #38600
• @bsunanda Phase2-hgx316F Modify the validation test scripts to accommodate the new geometry of HGCal (D93) #38587
• @jeongeun Replace Geometry_cff with GeometryDB_cff in RecoLocalMuon #38549

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee2beb/26095/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee2beb/26095/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 661 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654999
• DQMHistoTests: Total failures: 10371
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3644606
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 8218.428 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 1369.738 KiB HLT/B2G
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

@bsunanda please squash

[bsunanda]

@tvami Did the squashing

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38662/30963

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #38662 was updated. @malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee2beb/26106/summary.html
COMMIT: 25f0bca
CMSSW: CMSSW_12_5_X_2022-07-10-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38662/26106/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3655970
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3655940
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• LTO release compiles

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1