Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2G SD mass jet trigger DQM #38600

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Conversation

finnlabe
Copy link
Contributor

@finnlabe finnlabe commented Jul 5, 2022

PR description:

Update of the B2G HLT DQM code to include monitoring of two newly added triggers: HLT_AK8PFJet400_MassSD30_v and HLT_AK8DiPFJet250_250_MassSD30_v. The JIRA ticket of the integration of these triggers is linked here. The topic of jet mass trigger DQM, and these updates, were discussed in this B2G meeting.

The new paths have the same monitoring as the already previously included HLT_AK8PFJet400_TrimMass30_v except for a change in pt threshold and SD mass binning, which were also applied to the old HLT_AK8PFJet400_TrimMass30_v.

This PR aims for inclusion in the next possible release.

PR validation:

The complete workflow was tested using runTheMatrix.py -l 11634.0 verifying that the histograms are properly created. The changes were also tested by running the DQM and harvesting steps on different RelVal samples, to check whether the histograms are properly filled. The basic test procedure as instructed in the CMSSW PR instructions was run and passed all tests.

I hope the above information is complete, if not I'd be happy to provide anything that might be needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38600/30872

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

A new Pull Request was created by @finnlabe (Finn Labe) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@HuguesBrun, @mtosi, @Fedespring, @missirol, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9493e/26059/summary.html
COMMIT: ec43a9e
CMSSW: CMSSW_12_5_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38600/26059/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654747
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8218.428 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1369.738 KiB HLT/B2G
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants