Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errorScale for BeamSpot Legacy DQM client #38632

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

Forward-port of #38618 (12_3_X PR)
This PR updates the errorScale parameter from 1.22 to 1.0, see the 12_3_X PR for more details

PR validation:

The 12_3_X PR (#38618) deployed in production in Fill 7923 shows the beamspot legacy client properly working, see #38618 (comment) and #38618 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Forward port of #38618
Backports to 12_4_X and 12_3_X will be provided

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

+db

  • verbatim forward-port of the 12_3_X PR which is already in production

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38632/30920

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fadd5e/26054/summary.html
COMMIT: 4946918
CMSSW: CMSSW_12_5_X_2022-07-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38632/26054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654735
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2022

@cms-sw/dqm-l2 you signed the backport version of this PR, and not this one in the master: should I give the signature here for granted and bypasss it, or is there any reason for not signing this onw?

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2022

merge

@cmsbuild cmsbuild merged commit 1a0d127 into cms-sw:master Jul 7, 2022
@emanueleusai
Copy link
Member

apologies for whatever reason I missed this in our PR tracking tool

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants