[12_3_X] Update errorScale for BeamSpot Legacy DQM client

[francescobrivio]

PR description:

It was noticed in recent fills with stable beams (from 5^th July 2022 onwards) that the Legacy BeamSpot DQM client was consistently failing in fitting the beamspot, the issues seem related to the PV part of the beamspot fit.

After some excellent online debugging @mmusich found that after changing the errorScale parameters from the default 1.22 to 1.0 the fits were converging with beamspot results compatible with those measured by the other BeamSpot client.

This PR changes:

• the errorScale parameter to 1.0 for the Legacy BeamSpot DQM client (beam client)
• temporarily changes the target tag to which the BeamSpot fitted values are uploaded, from BeamSpotOnlineLegacy to BeamSpotOnlineLegacyTestRun3 so we can test the client with the upcoming stable beams and verify that it works properly before putting it in production.

PR validation:

• Code compiles
• Unit test runs
• Tested with different flavours of input data (ALCARECO, FEVT...)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, we will decide on the final integration of this PR after seeing it in production.

FYI @mmusich @gennai @dzuolo @sikler

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Update errorScale for BeamSpot Legacy DQM client #38632

[francescobrivio]

@cmsbuild please test

[emanueleusai]

testing at p5

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c877c8/26019/summary.html
COMMIT: d54d085
CMSSW: CMSSW_12_3_X_2022-07-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38618/26019/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626403
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3626379
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

just to say that in last night fill with this PR included in online DQM the legacy client has worked properly: https://cern.ch/go/nrN7

[francescobrivio]

Thanks Marco! I was about to post the exact same plot 😄
Let me add a link to the BeamMonitorLegacy DQM folder as well for reference.

I'll revert the tag to be the production one and make the forward ports to 12_4_X and master.

[cmsbuild]

Pull request #38618 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[francescobrivio]

+db

• re-signing, just changed back the tag name to the production one since the test online was successful (see [12_3_X] Update errorScale for BeamSpot Legacy DQM client #38618 (comment) and [12_3_X] Update errorScale for BeamSpot Legacy DQM client #38618 (comment))

[mmusich]

@francescobrivio are the forward ports also?

[francescobrivio]

@francescobrivio are the forward ports also?

I'm preparing them now!

[francescobrivio]

backport of #38632

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c877c8/26049/summary.html
COMMIT: b2d5ab4
CMSSW: CMSSW_12_3_X_2022-07-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38618/26049/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626403
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3626367
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

urgent

• @cms-sw/orp-l2 also this PR would be nice to have it included in case a 12_3_X is built in the next hours, so it doesn't have to be applied manually in P5 DQM machines

[perrotta]

+1