[Backport][GEM] bug fix in orbit counter checker between AMC13 and GEM AMC headers [12_3_X]

[yeckang]

PR description:

Because of the different implementations of orbit counter in AMC13 and GEM AMC, the OC value from GEM AMC should be subtracted with 1 or 2.

• Substract 1 orbit when the AMC13 bunch counter is [1,3563]
• Substract 2 orbits when the AMC13 bunch counter is 0

Because of the wrong implementation of data status checker, we couldn't unpack the data from GEM at the moment.

PR validation:

The branch is applied with scram build code-format and scram build code-checks.
The unpacking test on the data from the compatible firmware version has been performed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

The original PR #38544

[cmsbuild]

A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_12_3_X.

It involves the following packages:

• DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @rovere, @eyigitba, @jshlee, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from [GEM] bug fix in orbit counter checker between AMC13 and GEM AMC headers #38544

[perrotta]

backport of #38544

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce96a4/25875/summary.html
COMMIT: a99221e
CMSSW: CMSSW_12_3_X_2022-06-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38546/25875/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626218
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3626188
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[quark2]

Hi,

this PR is needed to be deployed to the onlineDQM release.
It's already mentioned here, but just for making sure.

[civanch]

+1

[cmsbuild]

Pull request #38546 was updated. @cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please check and sign again.

[quark2]

Hi @emanueleusai,

sorry for this, but we also need to deploy this update to the onlineDQM release. Could you add it?

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce96a4/25933/summary.html
COMMIT: c5c69c6
CMSSW: CMSSW_12_3_X_2022-06-30-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38546/25933/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626218
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3626182
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

Backport PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[emanueleusai]

Hi @emanueleusai,

sorry for this, but we also need to deploy this update to the onlineDQM release. Could you add it?

retesting at P5, will redeploy after tests

[quark2]

Hi @emanueleusai,

Thanks a lot!