[GEM] bug fix in orbit counter checker between AMC13 and GEM AMC headers

[yeckang]

PR description:

Because of the different implementations of orbit counter in AMC13 and GEM AMC, the OC value from GEM AMC should be subtracted with 1 or 2.

• Substract 1 orbit when the AMC13 bunch counter is [1,3563]
• Substract 2 orbits when the AMC13 bunch counter is 0

Because of the wrong implementation of data status checker, we couldn't unpack the data from GEM at the moment.
Backport PR to 12_3_X and 12_4_X is needed.

PR validation:

The branch is applied with scram build code-format and scram build code-checks.
The unpacking test on the data from the compatible firmware version has been performed.

@jshlee

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38544/30779

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @yeckang (Yechan Kang) for master.

It involves the following packages:

• DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @rovere, @eyigitba, @jshlee, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96fcca/25874/summary.html
COMMIT: a307304
CMSSW: CMSSW_12_5_X_2022-06-28-1500/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38544/25874/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654586
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3654556
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

type bug-fix

[srimanob]

+Upgrade

Bug fix for unpacking. As mentioned in the PR description, the unpacking test on the data from the compatible firmware version has been performed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[qliphy]

+1