Don't save flat nano in the ECAL ALCANANO wf

[tvami]

PR description:

Temporary solution to resolve the problems in dmwm/T0#4664
In the future, the ECAL experts will introduce another customization function that keeps the save_flatnano flag true, but for the T0 it needs to be False (given that T0 can deal with the EDM version of NANO only). Because of that I remove the output definition from the current ECAL ALCANANO customization.

PR validation:

runTheMatrix.py -l 139.005

runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, we could consider backporting it to 12_4_X

[tvami]

type ecal

[tvami]

urgent

• we should have this in the next 12_5_X_pre

[tvami]

test parameters:

• workflows = 139.005

[tvami]

atn @simonepigazzini

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38510/30740

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• Calibration/EcalCalibAlgos (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich, @ChrisMisan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[simonepigazzini]

ok for me. I will add the other customize function in a separate PR later on.

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25805/summary.html
COMMIT: 9b140d1
CMSSW: CMSSW_12_5_X_2022-06-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38510/25805/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @agrohsje fixing names in fragments for 13p6 CPx tunes #38502
• @mandrenguyen Factor of 2 bugfix for HF PF rechits w/ short-fiber only #38464
• @AdrianoDee Update XiMinus_14TeV_SoftQCDInel_TuneCP5 config #38466
• @cms-trackeralign Follow up to new high granularity pixel alignment for the PCL #38508
• @alejands ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM #38427
• @Michael-Krohn HCAL: Bugfix of PFA1' Trigger Primitive algo by removing peak-finder #38488

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25805/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25805/git-merge-result

RelVals

• 139.005139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM/step2_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM.log

RelVals-INPUT

• 139.005139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM/step2_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM.log

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38510/30742

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #38510 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25810/summary.html
COMMIT: 8e3b829
CMSSW: CMSSW_12_5_X_2022-06-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38510/25810/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @agrohsje fixing names in fragments for 13p6 CPx tunes #38502
• @mandrenguyen Factor of 2 bugfix for HF PF rechits w/ short-fiber only #38464
• @AdrianoDee Update XiMinus_14TeV_SoftQCDInel_TuneCP5 config #38466
• @cms-trackeralign Follow up to new high granularity pixel alignment for the PCL #38508
• @alejands ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM #38427
• @Michael-Krohn HCAL: Bugfix of PFA1' Trigger Primitive algo by removing peak-finder #38488

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25810/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19e517/25810/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
39634.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-19e517/139.005_AlCaPhiSym2021+AlCaPhiSym2021+RECOALCAECALPHISYMDR3+ALCAECALPHISYM

Summary:

• No significant changes to the logs found
• Reco comparison results: 11201 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659995
• DQMHistoTests: Total failures: 6452
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 3653517
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.035 KiB( 49 files compared)
• DQMHistoSizes: changed ( 138.4 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 138.5 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
• Checked 211 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 49 workflows

[tvami]

+alca

• tests pass, ECAL is in agreement with the proposed change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1