Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BuildRules] Fixed code and header checks for alpaka #7960

Merged
merged 3 commits into from
Jun 27, 2022
Merged

[BuildRules] Fixed code and header checks for alpaka #7960

merged 3 commits into from
Jun 27, 2022

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 26, 2022 •
edited
Loading

  • header checks: add alpaka-serial dependnecy if package depend on alpaka
  • Only run clang-tidy checks for alpaka/serial products

@smuzaffar
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_5_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar mentioned this pull request Jun 26, 2022
Closed
2 tasks
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25807/summary.html
COMMIT: 4ca64de
CMSSW: CMSSW_12_5_X_2022-06-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7960/25807/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25807/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25807/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
39634.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11209 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659995
  • DQMHistoTests: Total failures: 6460
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3653509
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.035 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 138.4 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 138.5 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 49 workflows

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7960 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7960 was updated.

@smuzaffar smuzaffar merged commit 6fcc0ba into IB/CMSSW_12_5_X/master Jun 27, 2022
@cmsbuild cmsbuild mentioned this pull request Jun 27, 2022
Merged
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25818/summary.html
COMMIT: 9c6bfe7
CMSSW: CMSSW_12_5_X_2022-06-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7960/25818/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25818/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b89f7/25818/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testSerializationEcalObjects had ERRORS
---> test test_occi_std_length had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
39634.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11202 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659995
  • DQMHistoTests: Total failures: 6556
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3653413
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.035 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 138.4 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 138.5 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 49 workflows

This was referenced Jun 27, 2022
Merged
Merged
Merged
@smuzaffar smuzaffar deleted the smuzaffar-patch-2 branch June 28, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild