-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce era with CKF pixelLessStep #38437
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38437/30638
|
A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master. It involves the following packages:
@perrotta, @clacaputo, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: Build BuildI found compilation error when building: >> Plugins of all types refreshed. gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1826: CompilePython] Error 1 gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-20-1100' gmake: *** [config/SCRAM/GMake/Makefile.rules:1714: src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 + eval scram build outputlog '&&' '(python3' /pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /pool/condor/dir_155243/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-06-20-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package Configuration/Eras |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38437/30644
|
Pull request #38437 was updated. @perrotta, @clacaputo, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-753264/25646/summary.html Comparison SummarySummary:
|
+reconstruction
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
[124X (backport)] Introduce era with CKF pixelLessStep: backport of #38437
I'm helping @bbilin understand why this new Era is not recognized when running the driver in 12_4_1 with error:
I guess the new era should have been added in: cmssw/Configuration/StandardSequences/python/Eras.py Lines 36 to 41 in 3b20114
@cms-sw/reconstruction-l2 can you confirm? |
Fix PR #38437 to disable mkFit in pixelLessStep
I don't have first-hand knowledge with it, but reading the code, this looks to be the case. Does it work when you add it there? |
CMSSW_12_4_1_patch1 was built this morning with that fix included. |
Yes the era needs to be added there, also there was a typo in the name of the config file:
See the PRs from Mario linked just above with the fixes. |
PR description:
This PR introduces a new era modifier where mkFit is disabled for PixelLessStep.
This is meant as a (temporary) fix for the inefficiency previously reported by BPH (https://indico.cern.ch/event/1166179/#3-feedback-from-bph-on-mkfit).
PR validation:
As described in https://indico.cern.ch/event/1169208/#5-mkfit-cross-check-of-ineffic