Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rawprime workflow with approximated siStrip clusters for heavy ions #38423

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

mandrenguyen
Copy link
Contributor

@mandrenguyen mandrenguyen commented Jun 20, 2022

PR description:

This PR contains the code needed to run a full reconstruction workflow using a modified data format which explicitly stores an approximated version of siStripClusters rather than full strip tracker RAW information. The motivation for this is to reduce the size of the RAW data format to more efficiently utilize HLT bandwidth during Run 3 (see slides 1-6 here) [1]. The approximated siStripClusters assume a rectangular cluster shape rather than storing a detailed list of ADC counts for each cluster. Note that the RAW data size is not actually reduced in this PR, this will come in second PR.

These approximated clusters are interfaced with the rest of the tracking sequence by converting them back into a collection of SiStripCluster objects at the beginning of the local reco sequence (instead if generating the clusters from RAW data). We have found that the changes to the cluster shape cause small differences in the tracking, on the order of 1% or less in MB heavy ion data, with the new procedure having slightly less tracks. A summary of the tracking performance using the performance of the 2018 reconstruction as a baseline can be found at [2]. This has been shown multiple times in HI PAG meetings.

It should be noted that we also turn off the cluster subshape filter in the pixelless and tob/tec tracking iterations. These were found to have a large sensitivity to the approximated cluster procedure, but were not found to strongly affect the tracking output when using regular clusters. Thus, we believe it is better to just remove this from the sequence.

Based on small tests with MB events, we expect a modest (~2%) increase in the timing of the reconstruction with this change, due to the removal of cluster shape filters, and no significant effect on memory usage.

[1] https://indico.cern.ch/event/1028779/contributions/4319687/attachments/2227865/3774300/RAW_DataFormat_Run3_Baty.pdf
[2] https://indico.cern.ch/event/1170543/contributions/4916527/attachments/2460140/4217789/ApproximateClustersHI_June10.pdf

PR validation:

This PR may be tested by the new relval worflows 161 (MC) and 140.58 (Run 2 data), which add a "RawPrime" step. Note that in Run 3 the functionality will be implemented instead in the HLT menu, such that it will already be applied in the input RAW data.

@abaty @icali

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38423/30629

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • DataFormats/SiStripCluster (reconstruction)
  • RecoLocalTracker/Configuration (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)
  • RecoTracker/IterativeTracking (reconstruction)

@perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @pieterdavid, @robervalwalsh, @kpedro88, @Martin-Grunewald, @trtomei, @threus, @mmusich, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @yduhm, @GiacomoSguazzoni, @rovere, @VinInn, @alesaggio, @ebrondol, @mtosi, @fabiocos, @swertz, @gbenelli, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2022

assign trk-dpg

@cmsbuild
Copy link
Contributor

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2022

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38423/30636

@cmsbuild
Copy link
Contributor

Pull request #38423 was updated. @perrotta, @connorpa, @kskovpen, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @tsusa, @slava77, @jpata, @qliphy, @mmusich, @fabiocos, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2022

test parameters:

  • workflows = 161, 140.58

@kskovpen
Copy link
Contributor

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

+1

@clacaputo
Copy link
Contributor

+reconstruction

@perrotta
Copy link
Contributor

@cms-sw/upgrade-l2 your signature was requested because of Configuration/PyReleaseValidation (pdmv, upgrade)
I don't think that this PR touches any upgraded related config in particular, but maybe I am missing some. Could you please let us know whether you intend to review it, or just say "+1" to tell us that we can go ahead and merge it. Thank you!

@srimanob
Copy link
Contributor

+Upgrade

For Upgrade, this PR adds step and workflow to Configuration/PyReleaseValidation. New workflows run fine.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.